nextauthjs / next-auth

Authentication for the Web.
https://authjs.dev
ISC License
24.96k stars 3.52k forks source link

Resent changes to authjs-sveltekit breaks compatibility with latest released SvelteKit #9667

Closed xmlking closed 10 months ago

xmlking commented 10 months ago

Environment

System: OS: macOS 14.2.1 CPU: (10) arm64 Apple M1 Max Memory: 35.83 GB / 64.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 21.5.0 - /opt/homebrew/bin/node npm: 10.2.4 - /opt/homebrew/bin/npm pnpm: 8.14.1 - /opt/homebrew/bin/pnpm bun: 1.0.19 - /opt/homebrew/bin/bun Browsers: Chrome: 120.0.6099.216 Safari: 17.2.1 npmPackages: @auth/core: 0.21.0 => 0.21.0 @auth/hasura-adapter: 0.2.14 => 0.2.14 @auth/sveltekit: 0.6.0 => 0.6.0

Reproduction URL

https://github.com/nextauthjs/next-auth-example

Describe the issue

vite build command failed with following error

image

Root cause: latest changes to this file added env.AUTH_REDIRECT_PROXY_URL where env is dynamic i.e., import { env } from "$env/dynamic/private"

https://github.com/nextauthjs/next-auth/blob/46264fb42af4c3ef7137a5694875eaa1309462ea/packages/frameworks-sveltekit/src/lib/index.ts#L205

Recently SvelteKit prevent using $env/dynamic/private while prerendering please use alternative methods

How to reproduce

pnpn run build

Expected behavior

Please also see https://github.com/nextauthjs/next-auth/issues/9436

github-actions[bot] commented 10 months ago

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository. Example: (NextAuth.js example repository).

The bug template that you filled out has a section called "Reproduction URL", which is where you should provide the link to the reproduction.

What should I do?

Depending on the reason the issue was closed, you can do the following:

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every issue and monitor open issues for new comments.

However, sometimes we might miss a few due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources