ensure we properly escape such that special characters will work

[mgallien]

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

[X-dark]

Latest patch version is not working with pgsql. Filenames are interpreted as column name instead of value.

[X-dark]

For postgresql, sed escaping is unnecessary. What works for me is:

mtime_in_db=$(
  psql \
    "postgresql://$db_user:$db_pwd@$db_host/$db_table" \
    --tuples-only \                                                                                                                                                     
    --no-align \
    -E 'UTF-8' \
    --command="\
      SELECT mtime
      FROM oc_storages JOIN oc_filecache ON oc_storages.numeric_id = oc_filecache.storage \
      WHERE oc_storages.id='home::$username' AND oc_filecache.path=\$\$${relative_filepath_without_username}\$\$"
)

This relies on Dollar-Quoted Strings constants: https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS

[mgallien]

For postgresql, sed escaping is unnecessary. What works for me is:

mtime_in_db=$(
  psql \
    "postgresql://$db_user:$db_pwd@$db_host/$db_table" \
    --tuples-only \                                                                                                                                                     
    --no-align \
    -E 'UTF-8' \
    --command="\
      SELECT mtime
      FROM oc_storages JOIN oc_filecache ON oc_storages.numeric_id = oc_filecache.storage \
      WHERE oc_storages.id='home::$username' AND oc_filecache.path=\$\$${relative_filepath_without_username}\$\$"
)

This relies on Dollar-Quoted Strings constants: https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-CONSTANTS

thanks @X-dark (by the way one of my former colleague is sharing your full name, how funny !)

[artonge]

Adapted the solution for pgsql, and fixed a problem with trailing line return added in the encoded value.

Tested with filename containing ', ", (, and ;.