nextcloud-libraries / nextcloud-dialogs

Nextcloud dialog helpers https://npmjs.org/@nextcloud/dialogs
https://nextcloud-libraries.github.io/nextcloud-dialogs/
GNU Affero General Public License v3.0
19 stars 9 forks source link

[stable4] fix(deps): bump @nextcloud/files to 3.0.0 #1347

Closed st3iny closed 3 months ago

st3iny commented 3 months ago

The required @nextcloud/files dependency is broken and fixing this inside other apps is hacky because the package lock has to be adjusted manually. It would be nice to release a 4.x.x version with the fixed dependency to make it easier to fix downstream.

Note that simply adding @nextcloud/files as a dependency to an app's package.json does not work because it is not a peer of @nextcloud/dialogs. Thus, npm will just install both versions separately.

E.g. in Deck:

@nextcloud/files@3.0.0-beta.21
node_modules/@nextcloud/dialogs/node_modules/@nextcloud/files
  @nextcloud/files@"3.0.0-beta.21" from @nextcloud/dialogs@4.2.7
  node_modules/@nextcloud/dialogs
    @nextcloud/dialogs@"^4.2.2" from the root project

@nextcloud/files@3.2.1
node_modules/@nextcloud/files
  @nextcloud/files@"^3.0.0" from the root project

Ref

Exemplary (hacky) downstream fix at https://github.com/nextcloud/calendar/pull/6035

susnux commented 3 months ago

No this will break server on Nextcloud 27!

stable4 is only intended to be used with Nextcloud <= 27. If you need to support a wider range please use v5 which also will work with Nextcloud 28+ and probably even 27.

susnux commented 3 months ago

See also: