Closed dvaerum closed 1 month ago
Thanks Denis! We'll investigate :)
Hey @susnux
Do you know there I find the rules for commit messages because it looks like I need to update one of them
Block unconventional commits / Block unconventional commits (pull_request)
It is obvious what I need to correct :confused:
Yes please squash you commits and use conventional commits like: fix(sorting): access displayname directly on Node
Hey @susnux
I believe that I have fixed the commit names. I didn't find your YAML config for configuring git-conventional-commits, so I just went with the one used in the example here: https://github.com/qoomon/git-conventional-commits?tab=readme-ov-file#config-file
Hey Nextcloud people.
I can see that I get a lot of these warning in the console of my browser (Firefox). They are floating my console so much that it prevents me from using it to find another bug/issue/problem on Nextcloud :sweat:
and I believe that I have traced it down to this line
https://github.com/nextcloud-libraries/nextcloud-files/blob/ae0a991cf74d2444f1c8af9637cdea904f978de2/lib/utils/fileSorting.ts#L68
Which uses
v.attributes?.displayname
instead ofv.displayname
.Sorry, I don't follow the contributor guidelines, but I did not see any.