search

nextcloud-libraries / nextcloud-files

Nextcloud Files helpers for Nextcloud apps and libraries https://npmjs.org/@nextcloud/files
https://nextcloud-libraries.github.io/nextcloud-files
GNU Affero General Public License v3.0
26 stars 11 forks source link

Make fileActions available for shares #964

Closed StCyr closed 3 months ago

StCyr commented 3 months ago

It might be great if Nextcloud Apps could create fileActions to be available for shared files

use case is the SignLive app where we would like to be able to let guests sign pdf files

skjnldsv commented 3 months ago

What do you mean shared files? You mean in public view mode ?

StCyr commented 3 months ago

hmmm I probably mean that :laughing:

I mean files that are shared with unauthenticated users, like when they are shared with a link... I think it relates to the following route in app file_sharing:

                [
                        'name' => 'Share#showShare',
                        'url' => '/s/{token}',
                        'verb' => 'GET',
                        'root' => '',
                ],
susnux commented 3 months ago

Needs: https://github.com/nextcloud/server/issues/42968

skjnldsv commented 3 months ago

Yeah, when it's done, you should be able to register file actions the very same way than the authenticated Files app.

skjnldsv commented 3 months ago

Closing as this is not related to this library and /theoretically/ already supported

skalteis commented 2 months ago

Closing as this is not related to this library and /theoretically/ already supported

Sorry for hijacking this closed issue - would it be possible to please elaborate a bit on the "already supported" part? The DICOMviewer app lost support for displaying images in folders shared via public share links recently and nothing I see in @nextcloud/files registerFileAction seems to be related to share links. Would be really grateful for any pointers so I could try my hand at hacking some support back in (not a maintainer, just a frustrated user/admin). Thank you!

susnux commented 2 months ago

I see [nothing] in @nextcloud/files registerFileAction seems to be related to share links.

@nextclou/files are helpers to work in general with files and especially to provide public API for the files app. Currently the modern files list is only used for authenticated users, for public link shares still the legacy file list is used, so for public shares you would need to use the API you used with Nextcloud 27 and before.

We hope to switch the public shares file list to the modern file list soon.

skalteis commented 2 months ago

Thank you very much for your quick response, much appreciated! 👍