nextcloud-libraries / nextcloud-vue

🍱 Vue.js components for Nextcloud app development ✌ https://npmjs.org/@nextcloud/vue
https://nextcloud-vue-components.netlify.app/
Other
214 stars 84 forks source link

[2.6] Spacing issue for title input #1347

Open georgehrke opened 4 years ago

georgehrke commented 4 years ago

B621B5A6-6E61-4B93-BD5D-C24033A3999D

There is a no visible padding between sidebar border and text input.

Also reproducible https://nextcloud-vue-components.netlify.app/#/Components/App%20containers?id=appsidebar-1 0CDBCE19-9810-4972-8B1F-D64DC4115D3A

skjnldsv commented 4 years ago

Please check again with master.

raimund-schluessler commented 4 years ago

This is still the case, and it kind of was by design. @jancborchardt stated https://github.com/nextcloud/nextcloud-vue/issues/1090#issuecomment-670192205 that we don't want the title to move when switching to edit mode.

Hence, when we want padding on the left of the input and a static title, we would need to move the whole title to the right, which might look a bit weird in non-edit mode. Adding padding on the right should be simpler, as there usually is space left anyway.

So once we decided how it should look like, I can take care of it.

raimund-schluessler commented 4 years ago

By the way, your second screenshot shows to much padding on the right of the title if no tertiary action is present. I will adjust the visual tests and fix this.

georgehrke commented 4 years ago

Please check again with master.

Still the case in 2.6.4

raimund-schluessler commented 3 years ago

Ping @jancborchardt for input on the input 😉