nextcloud-libraries / nextcloud-vue

🍱 Vue.js components for Nextcloud app development ✌ https://npmjs.org/@nextcloud/vue
https://nextcloud-vue-components.netlify.app/
Other
214 stars 84 forks source link

Avatar menu in conversation can only be opened once #4008

Closed SystemKeeper closed 1 year ago

SystemKeeper commented 1 year ago

How to use GitHub


Steps to reproduce

  1. Join a conversation
  2. Click on another participants avatar

Expected behaviour

The "avatar menu" should open each time it's clicked

Actual behaviour

It only works on the first click

https://user-images.githubusercontent.com/1580193/223981465-69999a1e-3577-4915-a314-bf6b333a2447.mov

Talk app

Talk app version: c.nc.c & sermo.

This is found on the console. So not really sure if it's a problem on our side or on the cue-lib side?!

focus-trap.esm.js:328 Uncaught (in promise) Error: Your focus-trap must have at least one container with at least one tabbable node in it at all times
    at h (focus-trap.esm.js:328:13)
    at Object.activate (focus-trap.esm.js:590:9)
    at NcAvatar.js:2:9477
    at p (NcAvatar.js:2:2549)
    at Generator.<anonymous> (NcAvatar.js:2:3886)
    at Generator.next (NcAvatar.js:2:2912)
    at c (NcAvatar.js:2:8537)
    at o (NcAvatar.js:2:9631)
nickvergessen commented 1 year ago

NcAvatar is from the Vue lib, so I guess the bug is there?

nickvergessen commented 1 year ago

@Antreesy can you confirm?

Antreesy commented 1 year ago

Yes, nothing from our side is changing during this procedure.

For information: reproduced the issue to watch changes in data:

https://user-images.githubusercontent.com/93392545/224002162-5fdbf56d-dbf0-4af5-a9b1-496bf4a69539.mp4

SystemKeeper commented 1 year ago

The same happens on social if I access the timeline at apps/social/timeline/timeline and open a menu of a user. So guess it's safe to assume we are not the problem here.

nickvergessen commented 1 year ago

I guess the problem is the findOne endpoint that @ShGKme also had issues with

nickvergessen commented 1 year ago

Also happens at https://nextcloud-vue-components.netlify.app/#/Components/NcAvatar with "Avatar with preloaded status"