NcSelect jumps/resizes on focus

nextcloud-libraries / nextcloud-vue

🍱 Vue.js components for Nextcloud app development ✌ https://npmjs.org/@nextcloud/vue

https://nextcloud-vue-components.netlify.app/

Other

215 stars 85 forks source link

NcSelect jumps/resizes on focus #5874

Closed ChristophWurst closed 2 months ago

ChristophWurst commented 2 months ago

Default	Focus

Look at the elments below. They are pushed down.

The default border is thinner than the focus border. Do we need a negative margin of the diffence between the two borders? E.g. if the default border is 1px and focus is 2px, the element has to move up by 1px to make up for the increased size, and everything will stay at its place regardless of focus state.

ChristophWurst commented 2 months ago

@jancborchardt could you discuss this with your designers?

jancborchardt commented 2 months ago

@marcoambrosini @susnux @ShGKme this also came up in a design review. How do we best fix this?

ShGKme commented 2 months ago

@marcoambrosini @susnux @ShGKme this also came up in a design review. How do we best fix this?

Do you have it on the current @nextcloud/vue version?

ShGKme commented 2 months ago

Must be fixed by https://github.com/nextcloud-libraries/nextcloud-vue/pull/5883
I cannot reproduce anymore

ChristophWurst commented 2 months ago

Confirm it to be fixed via https://nextcloud-vue-components.netlify.app/#/Components/NcSelect