search

nextcloud / Android-SingleSignOn

Single sign-on for Nextcloud (Android Library Project)
GNU General Public License v3.0
70 stars 30 forks source link

Update R8/ProGuard section of README.md #635

Open connyduck opened 8 months ago

connyduck commented 8 months ago

closes #572

connyduck commented 8 months ago

Are there known breakages in downstream apps? For the two apps I worked with it was fine.

Unpublished commented 8 months ago

The news app had crashes related to sso with obfuscation enabled last time I tested.

In case you try to reproduce: I removed too broad rules like "keep all classes in all nextcloud news packages"

connyduck commented 7 months ago

I built the news-android app without -dontobfuscate. The resulting apk is about 7% smaller (4965kB vs 5319kB) and works just fine (as far as I can tell with my Nextcloud setup). I don't see any rules I'd call too broad.

Unpublished commented 7 months ago

I'd call -keep class de.luhmer.** { *; } too broad. But if it works now, fine :thumbsup:

connyduck commented 7 months ago

Oh that are the application classes, I was looking for com.nextcloud, my bad. Here is a suggestion to improve the situation: https://github.com/nextcloud/news-android/pull/1382/