nextcloud / activity

:zap: Activity app for Nextcloud
111 stars 62 forks source link

Vue settings modal #1265

Open Pytal opened 12 months ago

Pytal commented 12 months ago

Settings are currently in an accordion and should be moved into a modal using https://github.com/nextcloud/nextcloud-vue components image

sofiaronnkvist commented 11 months ago

Hi! I was asked to work on this issue, but am struggling to understand which Vue components are being mounted on the relevant PHP in the templates and how to work with the files in the js-folder. I'd appreciate it greatly if I could get some help with understanding the setup of the codebase better so I can work on this. @Pytal

Pytal commented 11 months ago

The current settings are in https://github.com/nextcloud/activity/blob/e25813860dcb8f04f5d029d24cdf45bb10973aa9/templates/stream.app.navigation.php#L42-L64, none in Vue yet

The markup above will have to be replaced with a mount point for the Vue component

You can mount your component by creating a new js file like https://github.com/nextcloud/activity/blob/e25813860dcb8f04f5d029d24cdf45bb10973aa9/src/settings-personal.js and adding an entry for it in https://github.com/nextcloud/activity/blob/e25813860dcb8f04f5d029d24cdf45bb10973aa9/webpack.js

Then you can install the dependencies compile the code with npm ci && npm run watch @sofiaronnkvist :)

susnux commented 8 months ago

@Pytal are you sure we need a modal for exactly one setting? The settings accordion button only contains the RSS link + a link to the settings app.

Pytal commented 8 months ago

Was the standard for app settings but feel free to move it elsewhere @susnux :)