search

nextcloud / activity

:zap: Activity app for Nextcloud
115 stars 65 forks source link

chore: Adjust add and delete icon colors to match server variables #1534

Closed stefan-niedermann closed 9 months ago

stefan-niedermann commented 9 months ago

:information_source: These colors are still hard coded. I could imagine adding a <style> tag to the svg icons to actually apply the colors based on the available variables. However this is some kind of paradigm change in handling svg icons, therefore I wanted to keep the change small.

Source of color codes: https://github.com/nextcloud/server/blob/1891ae121d80758ffaf537dd4d4fffbaed3eef00/apps/theming/css/default.css#L24-L32

CC @nextcloud/designers

cypress[bot] commented 9 months ago

2 flaky tests on run #1198 ↗︎

0 10 0 0 Flakiness 2
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

chore: Adjust add and delete icon colors to match server variables
Project: Activity Commit: 5ab511abcf
Status: Passed Duration: 04:16 💡
Started: Jan 24, 2024 7:31 PM Ended: Jan 24, 2024 7:35 PM

Review all test suite changes for PR #1534 ↗︎

stefan-niedermann commented 9 months ago

Uh, I didn't know one can use CSS custom properties directly in fill attributes. I would have expected at least a style attribute. :)

ShGKme commented 9 months ago

Uh, I didn't know one can use CSS custom properties directly in fill attributes. I would have expected at least a style attribute. :)

Me too to be honest, but we have done it in many places recently 😀