search

nextcloud / activity

:zap: Activity app for Nextcloud
114 stars 64 forks source link

[stable29] forces sidebarPlugins to unmount and mount during an ActivityTab update #1771

Closed backportbot[bot] closed 3 weeks ago

backportbot[bot] commented 1 month ago

Todo

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

susnux commented 1 month ago

This resolves https://github.com/nextcloud/activity/issues/1772

susnux commented 1 month ago

/compile amend/

cypress[bot] commented 1 month ago

Activity    Run #1931

Run Properties:  status check failed Failed #1931  •  git commit 291195d379: [stable29] forces sidebarPlugins to unmount and mount during an ActivityTab upda...
Project Activity
Branch Review backport/1732/stable29
Run status status check failed Failed #1931
Run duration 05m 11s
Commit git commit 291195d379: [stable29] forces sidebarPlugins to unmount and mount during an ActivityTab upda...
Committer backportbot[bot]
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 8
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/sidebar.cy.ts • 2 failed tests • Run E2E View Output
Test Artifacts
Check activity listing in the sidebar > Has favorite activity Test Replay Screenshots
Check activity listing in the sidebar > Has rename activity Test Replay Screenshots
Flakiness  cypress/e2e/sidebar.cy.ts • 1 flaky test • Run E2E View Output
Test Artifacts
Check activity listing in the sidebar > Has tag activity Test Replay Screenshots