nextcloud / activity

:zap: Activity app for Nextcloud
115 stars 65 forks source link

Text file changes not summarized in activity notification e-mails #497

Open kostecke opened 4 years ago

kostecke commented 4 years ago

Steps to reproduce

  1. Open a file in the text editor
  2. Make a change
  3. Wait for an auto-save
  4. Make a change
  5. Wait for an auto-save
  6. Repeat as desired ...
  7. Receive an update notification e-mail containing a long list of closely spaced edits

Expected behaviour

One update notification per file for each editing session during a notification period similar to the summarized updates displayed in the file information pane.

Actual behaviour

One update notification for every auto-save triggered while a text file is edited. This can produce an update e-mail containing numerous edit notifications time stamped one minute apart.

This was an ongoing issue well before I reported it in https://github.com/nextcloud/text/issues/800 and has persisted across multiple upgrades. That issue report was closed and I was told to open an issue against nextcloud/activity.

Server configuration detail

Operating system: Linux 4.19.0-10-amd64 #1 SMP Debian 4.19.132-1 (2020-07-24) x86_64

Webserver: Apache (fpm-fcgi)

Database: mysql 10.3.23

PHP version:

7.3.19-1~deb10u1 Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, session, sodium, standard, cgi-fcgi, mysqlnd, PDO, xml, apcu, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, imagick, intl, json, exif, mysqli, pdo_mysql, apc, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Phar, Zend OPcache

Nextcloud version: 18.0.9 - 18.0.9.1

Updated from an older Nextcloud/ownCloud or fresh install: Updated from an older Nextcloud using builtin updater

Where did you install Nextcloud from: nextcloud website

Signing status Array ( )
List of activated apps ``` Enabled: - activity: 2.11.0 - admin_audit: 1.8.0 - cloud_federation_api: 1.1.0 - comments: 1.8.0 - dav: 1.14.0 - federatedfilesharing: 1.8.0 - federation: 1.8.0 - files: 1.13.1 - files_external: 1.9.0 - files_pdfviewer: 1.7.0 - files_readmemd: 1.1.4 - files_rightclick: 0.15.2 - files_sharing: 1.10.1 - files_texteditor: 2.11.0 - files_trashbin: 1.8.0 - files_versions: 1.11.0 - firstrunwizard: 2.7.0 - impersonate: 1.5.2 - issuetemplate: 0.7.0 - logreader: 2.3.0 - lookup_server_connector: 1.6.0 - nextcloud_announcements: 1.7.0 - notifications: 2.6.0 - oauth2: 1.6.0 - password_policy: 1.8.0 - photos: 1.0.0 - privacy: 1.2.0 - provisioning_api: 1.8.0 - recommendations: 0.6.0 - serverinfo: 1.8.0 - settings: 1.0.0 - sharebymail: 1.8.0 - survey_client: 1.6.0 - systemtags: 1.8.0 - text: 2.0.0 - theming: 1.9.0 - twofactor_backupcodes: 1.7.0 - updatenotification: 1.8.0 - user_usage_report: 1.2.3 - viewer: 1.2.0 - workflowengine: 2.0.0 Disabled: - accessibility - calendar - encryption - files_markdown - files_videoplayer - mail - socialsharing_email - support - user_ldap ```
Configuration (config/config.php) ``` { "updatechecker": false, "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "cloud.rrra.org" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "http:\/\/cloud.rrra.org", "dbtype": "mysql", "version": "18.0.9.1", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "logtimezone": "CDT", "installed": true, "loglevel": 2, "theme": "", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "memcache.local": "\\OC\\Memcache\\APCu", "maintenance": false, "data-fingerprint": "b0dfb2d05315edfc9c8add1fcd08327a", "mysql.utf8mb4": true, "updater.secret": "***REMOVED SENSITIVE VALUE***" } ```

Are you using external storage, if yes which one: n/a

Are you using encryption:

Are you using an external user-backend, if yes which one: n/a

Client configuration

Browser: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Operating system: Devuan 3.0

Logs

Web server error log ``` n/a ```
Nextcloud log ``` n/a ```
Browser log n/a
kostecke commented 4 years ago

Here's a sample notification e-mail:

chatty-activity-mail.txt

kostecke commented 3 years ago

I just upgraded our Nextcloud instance to 20.0.4 and observed that this issue is still present.

parfumdaventure commented 10 months ago

I have the same problem in nextcloud 25.0.13, not corrected...

nickvergessen commented 9 months ago

I have the same problem in nextcloud 25.0.13

25 is not supported anymore at this point.

parfumdaventure commented 9 months ago

I have the same problem in nextcloud 25.0.13

25 is not supported anymore at this point.

So this is corrected in newer version ?

kostecke commented 9 months ago

No, it is still present. Here is a sample from 2024-01-26:

Notification after a single editing session

Nextcloud: 27.1.6 Text: 3.8.0

Thanks!