nextcloud / all-in-one

📦 The official Nextcloud installation method. Provides easy deployment and maintenance with most features included in this one Nextcloud instance.
https://hub.docker.com/r/nextcloud/all-in-one
GNU Affero General Public License v3.0
4.73k stars 559 forks source link

Update reverse-proxy.md #4800

Open ArmanTheParman opened 1 month ago

ArmanTheParman commented 1 month ago

exclude mac for network=host

ArmanTheParman commented 1 month ago

OK, I learned something new

On Tue, 11 June 2024, 6:40 pm Simon L., @.***> wrote:

@.**** commented on this pull request.

In reverse-proxy.md https://github.com/nextcloud/all-in-one/pull/4800#discussion_r1634444194 :

@@ -39,7 +39,7 @@ In order to run Nextcloud behind a web server or reverse proxy (like Apache, Ngi

 For this setup, you can use as target `host.docker.internal:$APACHE_PORT` instead of `localhost:$APACHE_PORT`. **⚠️ Important:** In order to make this work on Docker for Linux, you need to add `--add-host=host.docker.internal:host-gateway` to the docker run command of your reverse proxy container or `extra_hosts: ["host.docker.internal:host-gateway"]` in docker compose (it works on Docker Desktop by default).
  • Another option and actually the recommended way in this case is to use --network host option (or network_mode: host for docker-compose) as setting for the reverse proxy container to connect it to the host network. If you are using a firewall on the server, you need to open ports 80 and 443 for the reverse proxy manually. By doing so, the default sample configurations that point at localhost:$APACHE_PORT should work without having to modify them.
  • In this case, another option, and actually the recommended way, is to use --network host option (or network_mode: host for docker-compose) as setting for the reverse proxy container to connect it to the host network. Do note that this method is not available on MacOS. If you are using a firewall on the server, you need to open ports 80 and 443 for the reverse proxy manually. By doing so, the default sample configurations that point at localhost:$APACHE_PORT should work without having to modify them.

as far as I know it also does not work on windows and in general on all platforms that use docker deesktop...

— Reply to this email directly, view it on GitHub https://github.com/nextcloud/all-in-one/pull/4800#discussion_r1634444194, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASQCCX5EFA2TMP4UPRKFQVDZG2ZY5AVCNFSM6AAAAABJAPXY4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBZG42DGNJQHE . You are receiving this because you authored the thread.Message ID: @.***>