search

nextcloud / android-config

Common configuration for Nextcloud android projects
GNU General Public License v3.0
7 stars 1 forks source link

Adopt base branch determination from talk-android #17

Open timkrueger opened 1 year ago

timkrueger commented 1 year ago

The GitHub base branch should be determined with the following snippet:

jq .base.ref

Example:

tobiasKaminsky commented 1 year ago

:+1: Right now we do not have this script here at all. Maybe we should consider to directly move entire script subfolder?

AlvaroBrey commented 1 year ago

Maybe we should consider to directly move entire script subfolder?

This would be a bad idea right now as scripts between Talk and Files (even between Files and library) have differences. Instead I'd rather move scripts here one by one, ensuring that each one works for all three projects and cleaning it up meanwhile.

When we do this we should also set up shellcheck and shfmt in CI here, by the way.

timkrueger commented 1 year ago

This would be a bad idea right now as scripts between Talk and Files (even between Files and library) have differences. Instead I'd rather move scripts here one by one, ensuring that each one works for all three projects and cleaning it up meanwhile.

I only added this issue as an reminder. But I think that will not work out to add an issue for every improvement. I think we must compare the solutions in Files and Talk and pick the best from both worlds.

When we do this we should also set up shellcheck and shfmt in CI here, by the way.

I didn't know about shfmt. Yes we definable must add that :-)