nextcloud / android-library

☎️ Nextcloud Android library
Other
91 stars 91 forks source link

Add New Capabilities For Compatible File Names #1494

Closed alperozturk96 closed 2 months ago

github-actions[bot] commented 4 months ago

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.24%. Comparing base (e9316a5) to head (56fb2f1). Report is 29 commits behind head on master.

Files Patch % Lines
...sources/status/GetCapabilitiesRemoteOperation.java 66.66% 0 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1494 +/- ## ============================================ + Coverage 49.16% 49.24% +0.07% - Complexity 1000 1005 +5 ============================================ Files 208 208 Lines 7819 7835 +16 Branches 1017 1021 +4 ============================================ + Hits 3844 3858 +14 + Misses 3421 3420 -1 - Partials 554 557 +3 ``` | [Files](https://app.codecov.io/gh/nextcloud/android-library/pull/1494?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud) | Coverage Δ | | |---|---|---| | [...cloud/android/lib/resources/status/OCCapability.kt](https://app.codecov.io/gh/nextcloud/android-library/pull/1494?src=pr&el=tree&filepath=library%2Fsrc%2Fmain%2Fjava%2Fcom%2Fowncloud%2Fandroid%2Flib%2Fresources%2Fstatus%2FOCCapability.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-bGlicmFyeS9zcmMvbWFpbi9qYXZhL2NvbS9vd25jbG91ZC9hbmRyb2lkL2xpYi9yZXNvdXJjZXMvc3RhdHVzL09DQ2FwYWJpbGl0eS5rdA==) | `94.20% <100.00%> (+0.35%)` | :arrow_up: | | [...sources/status/GetCapabilitiesRemoteOperation.java](https://app.codecov.io/gh/nextcloud/android-library/pull/1494?src=pr&el=tree&filepath=library%2Fsrc%2Fmain%2Fjava%2Fcom%2Fowncloud%2Fandroid%2Flib%2Fresources%2Fstatus%2FGetCapabilitiesRemoteOperation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud#diff-bGlicmFyeS9zcmMvbWFpbi9qYXZhL2NvbS9vd25jbG91ZC9hbmRyb2lkL2xpYi9yZXNvdXJjZXMvc3RhdHVzL0dldENhcGFiaWxpdGllc1JlbW90ZU9wZXJhdGlvbi5qYXZh) | `51.03% <66.66%> (+0.57%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/nextcloud/android-library/pull/1494/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nextcloud)
github-actions[bot] commented 4 months ago

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161
github-actions[bot] commented 4 months ago

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161
github-actions[bot] commented 3 months ago

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161
github-actions[bot] commented 2 months ago

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161
tobiasKaminsky commented 2 months ago

I'd like to have a test for this. But this would mean that we need to enable it via occ/config.php I asked Ferdinand.