search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.2k stars 1.75k forks source link

Upgrade to 3.20.x breaks auto upload (no longer detects new files and uploads) #10200

Open mepreston opened 2 years ago

mepreston commented 2 years ago

Steps to reproduce

  1. have version 3.19.1 installed
  2. upgrade to 3.20.0 or 3.20.1
  3. auto upload no longer works

Expected behaviour

Actual behaviour

Environment data

Android version: 10

Device model: moto g7 power

Stock or customized system:

Nextcloud app version: 3.20.x

Nextcloud server version: 23.0.4

Reverse proxy: no

workaround: downgraded to 3.19.1 and it is working fine again

AlvaroBrey commented 2 years ago

@AlvaroBrey seems like it might be a good idea to backport nextcloud/android-library#912 to stable so at least people hitting that issue stop commenting here/in case that's what's breaking auto upload?

That will be in 3.21.0, which should be the next release. Either way I don't think that will fix the problems with autoupload suddenly not working, just a somewhat related crash.

mepreston commented 2 years ago

i see this is still unassigned and still being ignored. without the +1 comments this is just being completely ignored. am i going to have to post to nextcloud notices on facebook and linkedin to get any traction on this? as i said before, it doesn't do any good to have a great server if the clients don't work and this is not working for me.

InfamousUser commented 2 years ago

You can complain all you want, autoupload hasn't been working for me for many years now (4, or more, I don't remember anymore), and nobody fixed that bug...

There's several issues wiht the way these bugs are being handled:

  1. Your forceful comment doesn't help the situation at all, you have no leverage to force them to do anything.
  2. Their handling of breaking bugs isn't something that is worth much either; if there are significant bugs stopping the whole program from working or a significant portion of it - this gets fixed - not postponed/ignored. It doesn't matter if it takes 2 years to fix it, as long as nothing else gets done until it is fixed. This destroys the users' confidence in the software.
  3. Nextcloud is a big community and of value to the whole world, lots of people migrate to this hoping it will be a dependable for their needs and then a main phone feature such as media backup doesn't work and this doesn't get fixed for years... you can see how this can aggravate a lot of users. There is no workaround for this.
  4. I tried as much as I could to provide any data needed to get these autoupload bugs fixed but it doesn't seem like there's anybody at the helm here. I appreciate all the developers that work(ed) on this and I'm very grateful for the time that they donated for free to this project but I'd much rather see bugs fixed than new features being developed/new bugs introduced. The issues are just piling up and piling up.
vgambier commented 2 years ago

I downgraded my android client to 3.19.1 to bypass this issue. If you need logs or anything that might help you pin point the issue, let me know.

tbleher commented 2 years ago

Is there an easy way to test the current master version of the app (without building the app oneself)? https://github.com/nextcloud/android-library/pull/912 mentions that it might fix the issue. Maybe someone could test this?

If current master is still not working, then a git bisect is probably the best way to find the faulty commit (but needs someone who has a working developer setup to build the app).

AlvaroBrey commented 2 years ago

Is there an easy way to test the current master version of the app (without building the app oneself)? nextcloud/android-library#912 mentions that it might fix the issue. Maybe someone could test this?

Nightly dev build: https://github.com/nextcloud/android#development-version-hammer

If current master is still not working, then a git bisect is probably the best way to find the faulty commit (but needs someone who has a working developer setup to build the app).

Not so easy, as this looks like it only breaks when upgrading (and I haven't been able to reproduce it anyway)

mindrunner commented 2 years ago

upgrading

upgrading what exactly?

I have two Nextcloud instances (mine and one for a customer). Mine is working perfectly fine. However, my customer complains about having the sync issue. Differences I can see:

Me: (working fine)

Customer: (broken sync)

AlvaroBrey commented 2 years ago

upgrading what exactly?

The app. from initial reports I understood that upgrading to 3.20.x in an already existing installation broke autoupload, but fresh installs work. This may no longer be the case, IDK

rcsilva83 commented 2 years ago

Same problem here with Xiaomi Poco F1

dwaxweiler commented 2 years ago

I can still confirm this issue for version 3.21.2. Reinstalling does not fix this.

rcsilva83 commented 2 years ago

I fixed it revoking app permissions and granting again.

mepreston commented 2 years ago

i seem to remember many version ago there was a way to get the client log without having to use ADB. I've offered to upload logs if there was a way to do so without adb. I've not no response to that. if you want to give customers better service it would be a good ideal to add back an option to enable client logging and view/copy the files to the server so they can be used to debug. this would also help those of use who manage servers to know if someone has mis-configured their phone and/or client.

AlvaroBrey commented 2 years ago

i seem to remember many version ago there was a way to get the client log without having to use ADB. I've offered to upload logs if there was a way to do so without adb.

On dev (daily) build and QA builds logs are available in the Settings screen. We've talked about making that available on production builds too, but can't tell you if/when it will be changed

Ixtalo commented 2 years ago

I fixed it revoking app permissions and granting again.

Thanks @rcsilva83 !

It seems to work again. What I did (Motorola G7+):

  1. Installed 3.21.2
  2. Revoked app permissions on storage and camera (via Android settings)
  3. restarted Nextcloud app
  4. granting permissions for camera and storage (via Android settings)
  5. in Nextcloud app, re-did setup for automatic upload folder (camera)
  6. new photos are uploaded automatically
DEvil0000 commented 1 year ago

revoking app permissions worked at first but it broke again. not sure due to a update, network change, app restart, phone restart or what else.. revoking and granting again quick fixed it again and it broke again maybe a hour to day later. so this is a workaround but not a solution since it reoccured on Nokia 9 (Android 10).

vgambier commented 1 year ago

I no longer have this issue on 3.23.0

Darkmagister commented 1 year ago

i'm still experiencing this issue with 3.24.0, revoking permission didn't fix it