nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.16k stars 1.75k forks source link

Share icons should be disabled if sharing is disabled. #12694

Open yurividal opened 6 months ago

yurividal commented 6 months ago

⚠️ Before posting ⚠️

Steps to reproduce

  1. Disabled all sharing features and share app.
  2. Open android app, find a folder with images
  3. Select large icon view
  4. Share icons overlay on top of every image, even when sharing is disabled.

[ Screenshot_20240316_074619_Nextcloud

Expected behaviour

Share icons should not appear

Actual behaviour

Share icons obstruct every image.

Android version

14

Device brand and model

Samsung Galaxy s23

Stock or custom OS?

Stock

Nextcloud android app version

3.28.0

Nextcloud server version

:latest

Using a reverse proxy?

Yes

Android logs

No response

Server error logs

No response

Additional information

No response

joshtrichards commented 6 months ago

Disabled all sharing features and share app.

Can you elaborate on how you disabled sharing features and the share app on your device?

yurividal commented 6 months ago

I mean I have disabled sharing and links in my nextcloud server. I am the only user and don't want to share anything with anyone.

From what I've investigated, it seems like the share button on the android app is for local sharing the file with other apps. In that case, I get why it's there. But it's obstructive, and this option should live inside the menu, not as on overlay to every file

joshtrichards commented 6 months ago

this option should live inside the menu, not as on overlay to every file

That's a debatable design matter and a fair point so I'll leave this open for that to be explored.

But I would encourage you to check the Media section for your use case. It's designed for browsing photos and videos and it does not have the share overlay. Where you're looking is the general Files explorer, which is more generalized as well as centered around displaying the file list with the same options that are offered when in the default (list) mode.