nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.3k stars 1.77k forks source link

First Run Activity Not Launching #13536

Closed alperozturk96 closed 1 week ago

alperozturk96 commented 2 months ago

⚠️ Before posting ⚠️

Steps to reproduce

  1. Have fresh install
  2. Open app

Expected behaviour

FirstRunActivity must appears

Actual behaviour

AuthenticationActivity appears instead FirstRunActivity

Android version

14

Device brand and model

Android Emulator

Stock or custom OS?

Stock

Nextcloud android app version

3.30.0

Nextcloud server version

29.0.4

Additional information

UserAccountManagerImpl.startAccountCreation starts AuthenticationActivity

OnboardServiceImpl.launchFirstRunIfNeeded starts FirstRunActivity if condition matches (firstRun condition was wrong I fixed but still AuthenticationActivity launched)

All these activities extends from BaseActivity and BaseActivity contains sessionMixin logic in onCreate which cause infinite loop to prevent that enableAccountHandling boolean variable used but still causing multiple activity launches and inconstancy for navigation.

This execution flow extremely error prone and buggy. Multiple place responsible for configuring the screen order.

joshtrichards commented 2 months ago

Reminds me of #4993 and #11392.