nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.18k stars 1.75k forks source link

MediaQuery: use "where" clause to exclude nextcloud folder #1397

Open tobiasKaminsky opened 7 years ago

tobiasKaminsky commented 7 years ago

Try to use something like "not like '%nextcloud%'" to exclude nextcloud folders while scanning for avilable auto upload folders. This should be better than the current implementation where we get a list of all possible images and filter them afterwards.

As discussed with @AndyScherzinger on the train ;-)

mario commented 7 years ago

What if I have a folder called nextcloud_123? That would exclude that too, and it shouldn't..

AndyScherzinger commented 7 years ago

Right, the idea would be to exclude the installation/storage path(s) of Nextcloud on the device. So yeah, the clause would have to be slightly more precise than just %nextcloud%.

tobiasKaminsky commented 6 years ago

Can we use MainApp.getStoragePath() for this? This should exclude all account folders. If so, then I would prepare a PR for this.

mario commented 6 years ago

No, because this is broken. See https://github.com/nextcloud/android/issues/1707.

joshtrichards commented 9 months ago

Should be less broken now since #1707 has been addressed.