search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.15k stars 1.75k forks source link

Add customizable delay on removal of original file #1588

Closed timmersr closed 6 years ago

timmersr commented 6 years ago

Actual behaviour

Received pictures are uploaded and removed directly, and are therefore not viewable by the apps.

Expected behaviour

Being able to at least see the received pictures for some time, before they are being removed by Nextcloud, even if conditions of "only upload via Wi-Fi" and "original file will be removed" are correctly met. A setting to upload immediatly, but only remove the original file after X time should fix this.

Steps to reproduce

  1. Set "only upload via Wifi" and "original file will be removed" preferences, and have an active wifi connection.
  2. Receive pictures in one of the monitored folders (ie. WhatsApp images)
  3. Pictures will be uploaded already -kudos!- and removed, therefore not viewable in WhatsApp.

Environment data

Android version: 7.0 Device model: Samsung Galaxy 6 Edge Plus Stock or customized system: Stock Nextcloud app version: 2.0.0RC7 Nextcloud server version: 12.0.3

Logs

Web server error log

Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

NOTE: Be super sure to remove sensitive data like passwords, note that everybody can look here! You can use the Issue Template application to prefill some of the required information: https://apps.nextcloud.com/apps/issuetemplate

tobiasKaminsky commented 6 years ago

I am unsure how to solve/enhance this. Auto upload is never meant to be "immediately", so it can be that there is already a delay due to android schedules the upload. Also adding another option is cluttering up the UI.

@jancborchardt maybe?

mario commented 6 years ago

FYI, I am strictly against this feature.

On Mon, Sep 25, 2017 at 12:14 PM, Tobias Kaminsky notifications@github.com wrote:

I am unsure how to solve/enhance this. Auto upload is never meant to be "immediately", so it can be that there is already a delay due to android schedules the upload. Also adding another option is cluttering up the UI.

@jancborchardt https://github.com/jancborchardt maybe?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/android/issues/1588#issuecomment-331838235, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAWsjx-KRqAE1m1LcLK5EyZc1FOGsUrks5sl30IgaJpZM4PiCt4 .

AndyScherzinger commented 6 years ago

I am also voting against this feature since this is an automation tool task (like tasker, locale etc.) so offering upload-only, upload-n-move, upload-n-delete is already quite the choice with delete being an issue depending on the folder location / write permissions...

jancborchardt commented 6 years ago

Exactly, we’re not adding yet another option here. It’s way too specific.

timmersr commented 6 years ago

FYI, my workaround is to disable "original file will be removed" for WhatsApp pictures, and then to delete manually afterwards.