search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.32k stars 1.78k forks source link

Remove auto upload behaviours #1686

Open mario opened 7 years ago

mario commented 7 years ago

There are several issues with auto upload behaviours, some of which can and some of which aren't that EASILY fixable.

Because the new Auto Upload overwrites files on the server (https://github.com/nextcloud/android/issues/1685), users think this is unwanted behaviour. Unfortunately this is indeed INTENDED - if you modify a file, you should get a file uploaded. And CREATE + DELETE + CREATE == modification.

In general, I think we should not touch the files outside our Nc data folder so I would suggest we completely eliminate Auto Upload behaviours.

mario commented 7 years ago

cc @AndyScherzinger @tobiasKaminsky

AndyScherzinger commented 7 years ago

I'd agree on this. While it seems nice to have the behaviors (others like dropbox don't) I think that there is a reason for the lack of this feature like already mentioned by @mario. Looking at the evolution of Android I'd also say that Google/Android doesn't want apps to fiddle with data outside their own data folder(s). So I'd also be fine with removing the behaviors (Google Photos, Dropbox also don't do this).

cc @jancborchardt

jancborchardt commented 7 years ago

Can you fill me in on this behavior? I'm not sure when it would occur that auto upload overwrites files on the server. Is it when you manually upload a picture before auto upload kicks in? If so, what's the problem about overwriting, since it should be the same file?

Also, what exactly do you mean by the "behaviors"? The options for "keep original file", move to app folder etc?

Anyhow from reading this it seems you already have a plan which sounds good and are in line with what other established apps are doing. :)

TheRealChriAnd commented 7 years ago

If using the behavior "move to app folder" all pictures are moved out of the original folder to the local nextcloud folder. Which is exactly what it's supposed to do. The problem occurs when using a camera app that names the pictures with a number depending on the number of pictures stored. For example if I take 3 pictures their names will be "photo_0001.jpg", "photo_0002.jpg" and "photo_0003.jpg". When they files then automatically get moved to the local nextcloud folder, the camera app will reset and start the naming from 1 again. So next time a picture is taken the name will be "photo_0001.jpg". That causes the auto upload to replace the file uploaded before with the same name. Of course it's very stupid of the camera app to name the files like this, but using a third-party app will not have the system specific features on Sony phones. In the last version of Nextcloud, all the pictures with the same name got a number in the end of the file indicating a copy. For example if "photo_0001.jpg" already exists then the new picture will be named like this "photo_0001 (1).jpg". Hope this describes the problem better.

muellert commented 7 years ago

My 0.02 cents on this: It would be nice if Nextcloud would have a files versioning behaviour, like eg. Google Drive or Syncthing. I am very keen on the auto-upload behaviour. But I am only a user...

joshtrichards commented 12 months ago

Is this still relevant? Are there really still camera apps in the field today that don't timestamp their filenames? :cry: