nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.17k stars 1.75k forks source link

User information leaking through debug logs. #2135

Closed ardevd closed 6 years ago

ardevd commented 6 years ago

adb logcat reveals several debug log entries marked with "GetRemoteUserInfoOperation". Here is one example.

02-09 23:12:33.410 28516 3060 D GetRemoteUserInfoOperation: Successful response: {"ocs":{"meta":{"status":"ok","statuscode":100,"message":"OK","totalitems":"","itemsperpage":""},"data":{"enabled":"true","id":"xxx","quota":{"free":110406975803,"used":50654297797,"total":161061273600,"relative":31.45,"quota":161061273600},"email":"xxx@xxx.xx","phone":"","address":"","website":"https:\/\/redacted.com","twitter":"@redacted","groups":["admin"],"language":"en","display-name":"Redacted"}}}

It makes sense to print these as a debugging measure, but it doesnt belong in a production ready deployment. My recommendation would either be to use a wrapper class to filter the log prints away from RELEASE builds or use Proguard to filter out the debug code completely.

The weird thing is that I havent been able to figure out where in the source these are coming from.

AndyScherzinger commented 6 years ago

The weird thing is that I havent been able to figure out where in the source these are coming from

Because this code is not in the app project but the library project :)

AndyScherzinger commented 6 years ago

@ardevd can you open this issue in the library project? That'd be great :)

ardevd commented 6 years ago

@AndyScherzinger cool, done!

przybylski commented 6 years ago

Closing since invalid