search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.16k stars 1.75k forks source link

Improve error infos on upload failure #260

Open AndyScherzinger opened 8 years ago

AndyScherzinger commented 8 years ago

As reported by @Bugsbane

Oh, something else that I was also running into, but I'm assuming is my Nginx setup - not the Android app - is that files over 1gb seem to fail when uploading. Even so, if possible it would be nice to let the user know why uploads failed.

Uploads view: Just the filename and then "Upload failed"

I think we should improve in this area, either via displaying a more detailed message or via activating the logging on stable clients (see #247) to give people the change to gain some more information. In general though I think more detailed error message might confuse since non-tech users might get confused but for error reporting and knowing what is going on it might be critical information. With failed downloads might might anyways have to implement some auto-restart, e.g. on the next wifi connect or else so users wouldn't even have to look into the uploads view and investigate...

what do you think @tobiasKaminsky and also @nextcloud/designers also from the UX/UI perspective since infos might get very technical

Bugsbane commented 7 years ago

I've always assumed that the client would retry failed uploads when a new network connection became available (at least non permanent fails like "couldn't reach server" as opposed to more permanent fails like where the local file has been deleted).

I often wondered why I was seeing failed uploads that then worked as soon as I manually retried them.

Side question: if a photo is uploaded by instant upload on a date later than when it was taken, with the "subfolders by date" option, is the date used for the folder based on when the photo was taken or uploaded? As a user, I would assume it would use the date the image was created.

AndyScherzinger commented 7 years ago

@Bugsbane at the moment there is no auto-retries in the client at all but might be one in the future with the revamped instant upload feature. So like you said, right now there is only the manual retry.

@Spacefish can you answer this question (I would have to check to code...):

Side question: if a photo is uploaded by instant upload on a date later than when it was taken, with the "subfolders by date" option, is the date used for the folder based on when the photo was taken or uploaded? As a user, I would assume it would use the date the image was created.

eppfel commented 7 years ago

When the error is known, infos help and can be translated into user-speech ^^ The info "the server did not accept your file, because it is too big." helps a lot. But if it is just catching errors, I would not directly force then on the user, but give him the freedom to investigate.

AndyScherzinger commented 7 years ago

@eppfel

When the error is known, infos help and can be translated into user-speech

We do that for errors that are specific enough that we actually "know" what the problem is :)

But if it is just catching errors, I would not directly force then on the user, but give him the freedom to investigate.

Let's discuss this. In general at the moment we just "save" the error and display it (translated to user friendly messages if it is a known issue), not sure how we could improve this but I am happy for any hint to improve this area! (since errors are not user friendly, ever)