search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.29k stars 1.77k forks source link

[3.3.0 RC1] Unlock with fingerprint not available #2968

Closed ffuentes closed 6 years ago

ffuentes commented 6 years ago

Actual behaviour

Expected behaviour

Environment data

Android version: 8.0.0.OPR1

Device model: Xiaomi Mix 2

Stock or customized system:

Nextcloud app version: v3.3.0 RC1

Nextcloud server version: 13.0.4

AndyScherzinger commented 6 years ago

@ffuentes thanks for the report. What setting is active in the apps settings screen for the app lock? (Can you post a screenshot of it maybe?) Thanks :)

ffuentes commented 6 years ago

Hi @AndyScherzinger , can't take screenshot it says is not allowed.

The settings was on and working before updating, after it. It posible to select credential, but it just ask for the code not the fingerprint.

Here are some photos... img_20180905_110308923

Not posible to take android screenshot. img_20180905_110743

AndyScherzinger commented 6 years ago

Ah, yeah, my mistake, screenshots are blocked on screens with possibly sensitive information.

@tobiasKaminsky do you have any idea what is happening here, @ardevd maybe or @rhari991 ?

AndyScherzinger commented 6 years ago

@ffuentes do you have a screenshot of the pin code screen (with keyboard hidden)?

AndyScherzinger commented 6 years ago

I checked it on my phone and it works fine, of course is asks for the credentials (PIN) or the fingerprint within the one screen

ffuentes commented 6 years ago

@AndyScherzinger it only ask for PIN when is selected access code. If I check credential it just open the app without fingerprint or PIN code.

img_20180905_180519652

flaviomeyer commented 6 years ago

@AndyScherzinger I have the same issue with fingerprint Authentication. Nextcloud want authenticate with Threema App :(

If you need some settings, ask me.

tobiasKaminsky commented 6 years ago

This is the old pin screen. This should only be shown with "pin" enabled and not "device credentials".

@meyerf99 what do you mean with "authenticate with threema app"?

flaviomeyer commented 6 years ago

@tobiasKaminsky When i want to open Nextcloud Android App it ask me for fingerprint. Thats normal because i set unlock with fingerprint. But with the newest Beta release v.3.3.0 RC1 it open Threema fingerprint unlock and not Nextcloud fingerprint unlock.

I can't take a screenshot because Threema doesn't allow screenshots.

tobiasKaminsky commented 6 years ago

With 3.3.0 we use the unlock screen from android. Maybe also Threema is using the same so it leads to the impression that it is the one from Threema… But @meyerf99 is it working for you to unlock the app?

flaviomeyer commented 6 years ago

@tobiasKaminsky Oke, no it is not possible. I think thats a big issue...

ffuentes commented 6 years ago

@tobiasKaminsky this is the android unlock screen?

This shows up only when changing from device credentials to access code, but after that it only prompts for the PIN code with the other screen.

img_20180907_102742366

flaviomeyer commented 6 years ago

@tobiasKaminsky & @AndyScherzinger

V.3.3.0 RC2 didn't solved my problem.

ffuentes commented 6 years ago

@AndyScherzinger @tobiasKaminsky me neither, RC2 still doesn't ask for fingerprint on my device, it just open the app.

AndyScherzinger commented 6 years ago

We know, RC2 just fixed two crashes in other areas of the app. As soon as we come up with a solution and implementation it would be linked against this issue. Still I have no clue how to solve this. @tobiasKaminsky maybe we need to offer the old fingerprint solution too for devices that don't support the Android device credentials Api properly :/

MeiRos commented 6 years ago

To me it says something like "use biometric or draw your pattern". Upper part of the screen is just white. I think there should be camera screen to help iris check. Now it's hard to find correct angle and position to check my iris. Any idea why it's like that?

The checking accepts fingerprint even it doesn't mention about it.

Lower part is for pattern. Dots where you draw. And it's working also.

My device is Samsung S8.

fdjean commented 6 years ago

Same here

Actual behaviour After upgrading to v3.3.0 RC2, unlocking with fingerprint is not available. Previous versions allow this. Expected behaviour Able to unlock with fingerprint. Environment data Android version: 7.1.2 Device model: Xiaomi Redmine 4 Prime Stock or customized system: Nextcloud app version: v3.3.0 RC2 Nextcloud server version: 14.0.0 RC2

warthog9 commented 6 years ago

So I'll tag onto this, after setting / un-setting credentials a bunch to get it reset (it seemed to require credentials with 'none' set for a bit), I got it back to asking for my login pin (the new menu), however just assuming my fingerprint would work (since my device is setup for it) did in fact unlock. That being said there's no indication of that being the case, and there's just the pin/pattern/etc unlock being shown so it's not obvious that fingerprint should work. I'm on Nextcloud app: v3.3.0 RC2

AndyScherzinger commented 6 years ago

@warthog9 the unlock screen you are seeing is from the operating system as-in Android not from the app, the app is just requesting the authentication via the operating system. I also don't see a fingerprint symbol on the screen before I close the virtual keyboard that comes up, so this in fact a quite weird UX decision by Google... :S

tobiasKaminsky commented 6 years ago

For me (emulator & OTP3 with LineageOS) it looks this way: image image

flaviomeyer commented 6 years ago

@tobiasKaminsky For me it looks like yours and it looks like Threema fingerprint authentication.

AndyScherzinger commented 6 years ago

@meyerf99 I guess threema, like nextcloud is using the Android OS authentication mechanism for the device credentials ;)

joekerna commented 6 years ago

Is this related to #3026 and #2879 ?

AndyScherzinger commented 6 years ago

I think so, yes

Pablohn26 commented 6 years ago

Same problem here with Xiaomi Mi Mix 2S and Nextcloud dev 20181013

flaviomeyer commented 6 years ago

@AndyScherzinger & @tobiasKaminsky It's horrible to work with this Nextcloud App version. It's not possible to log-in with fingerprint. ETA for fix?

p3x-robot commented 6 years ago

Not working in nextcloud server 14 and latest. Client either, android 7

tobiasKaminsky commented 6 years ago

We had a bug with fingerprint (un)lock mechansim. It affected only a few devices, e.g. Xiaomi, Motorola, … As none of our test deices was affected, hunting this bug down took a while.

If any of you could download and install this apk (https://cloud.nextcloud.com/s/pCwRFo7rFF3MMjM) and test if it is now working better, I would appreciate it. (the APK file is signed with the key for Google Play Store and is 3.3.2 Alpha 1, so this proves that it is an official version and can be easily upgraded. The up-to-come 3.3.2 version then can also just update this version).

p3x-robot commented 6 years ago

@tobiasKaminsky i tried it, but it is the same ... PIN code again ... No choice to use fingerprint, it only allows none, passcode or device credentials ...

p3x-robot commented 6 years ago

uses Huawei P9

p3x-robot commented 6 years ago

looks like this: image

joekerna commented 6 years ago

Does the fingerprint work, even though you're not asked for it? That's what's happening on my side (Also Huawei P9)

p3x-robot commented 6 years ago

the fingerprint works on android (enpass, global lock), only nextcloud android app is not working with fingerprint. using the latest version you provided.

tobiasKaminsky commented 6 years ago

Enabling it in settings: 2018-10-31-131212

After timeout (10s) I started NC app: (this screen can be a bit different, depending on vendor/device) screenshot_20181031_131256

tobiasKaminsky commented 6 years ago

@p3x-robot what is happening for you if you use the fingerprint? Nothing at all? Do you see an error?

p3x-robot commented 6 years ago

@tobiasKaminsky fingerprint is missing totally in this app. in global lock and enpass it works with fingerprint android v7... huawei p9... no info, or error completely. looks like the feature is missing in this release. in the previous versions working, i had a huge fingerprint icon. missing a well.

tobiasKaminsky commented 6 years ago

@p3x-robot this is really strange. We are checking if device is >= Android 6 and if a fingerprint is set up. If this is true, we show the possibility to use "device credentials" as lock mechanism.

Then we rely on a built-in method to display the fingerprint/pin lock screen like shown in my previous post. This is done & implemented by Android…

@p3x-robot on an older version (3.0) we had a different approach with a full screen fingerprint icon.

p3x-robot commented 6 years ago

maybe Huawei Android firmware implemented is different then the others? though with Enpass it works. Cant't it check the API level and use the older version that it was working? I am using the device credentials but it is missing the small fingerprint icon. I recognize it should show a pin and below a small fingerprint icon. But the pin is there but the small fingerprint icon is totally missing.. I rebooted, but this new versions is still as it was...

p3x-robot commented 6 years ago

i suppose the device credentials is not implemented in this firmware, missing the fingerprint icon with the pin code view.

p3x-robot commented 6 years ago

with Enpass it is not using the device credentials, it is also using a big fingerprint icon as well like the older netxtcloud version. maybe this pin code view is only working since Android 8... Totally there is no fingerprint in Android 7 with device credentials...

tobiasKaminsky commented 6 years ago

@p3x-robot can you compare with @joekerna as he also has a P9? And for him it is working… Maybe he has a newer android version?

p3x-robot commented 6 years ago

i got the latest Huawei P9 firmware, the latest is Android 7

p3x-robot commented 6 years ago

@joekerna for you Nextclud the fingerprint works???

joekerna commented 6 years ago

@joekerna for you Nextclud the fingerprint works???

Yes... No fingerprint symbol and I don't understand why I'm asked for a PIN also but fingerprint works just fine.

p3x-robot commented 6 years ago

@joekerna for you Nextclud the fingerprint works???

Yes... No fingerprint symbol and I don't understand why I'm asked for a PIN also but fingerprint works just fine.

How can you use fingerprint if there is no fingerprint symbol? how do you use it?

WOW! actually it works. but the icon is missing! when i put my finger on the fingerprint it works, WOW!!! VERY WEIRD!

p3x-robot commented 6 years ago

@tobiasKaminsky looks in the Android 7 implementation the device credentials is missing the icon, though it works... that is what is happening.

joekerna commented 6 years ago

@tobiasKaminsky looks in the Android 7 implementation the device credentials is missing the icon, though it works... that is what is happening.

:) that's what I was saying earlier. Not beautiful but working

tobiasKaminsky commented 6 years ago

Glad that it is working now also for you, @p3x-robot. @joekerna yeah, unfortunately there is nothing we can do here…

joekerna commented 6 years ago

Does Android provide options that change the way it looks? As mentioned it looks different (but the same) on apps like Lastpass, Enpass, comdirect trade, PayPal, Deutsche Bank,...

tobiasKaminsky commented 6 years ago

@joekerna can you give me some screenshots how it looks for you on NC an don other apps?