Switch to modern system

nextcloud / android

📱 Nextcloud Android app

https://play.google.com/store/apps/details?id=com.nextcloud.client

GNU General Public License v2.0

4.16k stars 1.75k forks source link

Switch to modern system #3146

Open tobiasKaminsky opened 5 years ago

tobiasKaminsky commented 5 years ago

Our current architecture system is really old and evolved over years. I think it is a good point to migrate it step by step to a modern system, as described here.

This is an overview, how it looks like:

In short:

separation of concerns
use Dagger2 for dependency injection (DI)
use Data Binding
use Room
use LiveData
use ViewModel
- to prevent rotation problems
- avoids async task problems
- share data between fragments: later usable for split view on tablets
- further reading
Network handling: https://developer.android.com/jetpack/docs/guide#addendum
benefit: get a more easy testing environment

I would like to test this first on UserInfo Activity as this is a nice well defined part of our app. I will add caching to it.

Later I would go with Activities, which will also benefit from caching.

nextcloud-android-bot commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/android/issues/1077 (Strange animations when switching sections), https://github.com/nextcloud/android/issues/689 (Switch to disable welcome guide), https://github.com/nextcloud/android/issues/185 (Upload view: switch to Grid view), https://github.com/nextcloud/android/issues/2087 (Switch UploadList from ListView to RecyclerView), and https://github.com/nextcloud/android/issues/155 ([RC1] Can't switch from "Uploads" to "All Files").

AndyScherzinger commented 5 years ago

Looks good to me :+1: While I have to say this is basically one of the overview tasks... simply because move on to Room it a big dev effort to be taken, so I'd say even this issues need to be split into several issues to be tackles one by one.

AndyScherzinger commented 5 years ago

You should be able to to activity by activity after the persistence migration while I am not sure you can split the Room migration into per activity issues, so I'd vote to to the Room migration as a separate, dedicated issue

Doomsdayrs commented 3 years ago

This feels more and more important, as the usage of nextcloud is like using my own app Shosetsu before I swapped over to async.

It is slow, lags, and feels buggy.

Doomsdayrs commented 2 years ago

Rename the issue to "Migration to MVVM"? Since that better fits the aim?