search

nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.29k stars 1.77k forks source link

Enhance uploads view #3646

Open tobiasKaminsky opened 5 years ago

tobiasKaminsky commented 5 years ago

From https://github.com/nextcloud/android/issues/3111#issuecomment-428331916

I'd rather argue that the uploads view should also get a three dot menu to offer similar actions than the file list view, while the menu should then only be present for successfully uploaded files. Would that work as an alternative way to handle this?

tobiasKaminsky commented 5 years ago

Duplicating all the actions is maybe too much, e.g. removing/adding favorites would then also have to add/remove favorite icon, etc.

nextcloud-android-bot commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/android/issues/311 (Finetune upload view), https://github.com/nextcloud/android/issues/1305 (Upload view: make undone possible), https://github.com/nextcloud/android/issues/2415 (Better Upload Options), https://github.com/nextcloud/android/issues/184 (Upload whole folder), and https://github.com/nextcloud/android/pull/3464 (Chunked upload).

AndyScherzinger commented 5 years ago

Alternatively we could just open the details view on click?

That would basically be what @jancborchardt wanted to happen when clicking on the notification (which we now removed since there has only been a notification for the last uploaded file, which is why we all agreed to remove it completely)

tobiasKaminsky commented 5 years ago

Alternatively we could just open the details view on click?

:+1:

What would happen if we click "back" on detail?

AndyScherzinger commented 5 years ago

In this case I'd say

* see uploads view again

--> it is a back navigation and back in this case means "uploads view"

tobiasKaminsky commented 5 years ago

Ok, but this will be a bit more work. But I guess that it is what user will expect.

AndyScherzinger commented 5 years ago

But I guess that it is what user will expect.

That is what I thought. To get this right we probably just need to send a flag when launching the activity/fragment. Right now it is a fragment while we could discsuss to make it its own activity which would also solve the sharing issue with previawable files (atm a separate sharing implementation) becuase then it would just be a flag + check with a simple backstack navigation / back-pressed thing :)

tobiasKaminsky commented 5 years ago

Having details as an activity will probably cause also trouble, as activity start different (slide up from bottom), …

I think (without diving too deep into it), a fragment will work. But we then would have to move all those sharing/other common functions into an interface, so that e.g. FDA (for details in file list) and UploadActivity (for details in upload view) can handle it. We can then also move common function into it (and do not use an Inferface, but an [abstract] class).

AndyScherzinger commented 5 years ago

Yeah, that might work but it would be nice if we then find a way to re-use it and also use it for the sharing action in the preview fragments...

mario commented 5 years ago

While I'll always advocate for one-activity app(s), if the way activity appears is your biggest trouble, there are certainly ways to change its enter and exit animations :)

AndyScherzinger commented 5 years ago

Imo the biggest issue is having a details fragment which we need to launch in 3 palces (atm used in one) which has a lot of dependencies to it's calling activity... (which is also why I thought it would be best to just give it an activity of its own since interfaces are nice bt having several activities implementing the exact same thing so they can use this fragment seems to be nonsense in my opinion.