nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.17k stars 1.75k forks source link

Android app not showing "Open with Collabora" for all filetypes supported by Collabora CODE #3650

Closed e-alfred closed 5 years ago

e-alfred commented 5 years ago

Actual behaviour

Using the Nextcloud Android app version 3.5.0 not all file types supported by Collabora CODE (for example .xls, .doc) can be opened with Collabora inside the Nextcloud app. These files also don't show the "Open with Collabora" menu item in the three-dot menu. Some filetypes like *.docx work flawlessly.

Expected behaviour

All filetypes supported by Collabora CODE should show the "Open with Collabora" menu item within the Nextcloud Android app and also open Collabora within the Nextcloud Android app.

Environment data

Android version: 7.1.1 Device model: BQ X5 Plus Stock or customized system: Lineageos 14.1 Nextcloud app version: 3.5.0 Nextcloud server version: 15.0.4 Collabora Online (NextcloudApp): 3.2.1 CODE: 4.0.0

nextcloud-android-bot commented 5 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/android/issues/1174 (Android O), https://github.com/nextcloud/android/issues/2920 (Android app crashes when opening the menu), https://github.com/nextcloud/android/issues/1160 (Images not showing up in app), https://github.com/nextcloud/android/issues/2026 (Supported Android versions), and https://github.com/nextcloud/android/issues/1667 (Android app doesn't show user icon if user name contains whitespace).

tobiasKaminsky commented 5 years ago

Android relies here on the capabilities sent by the server:

"mimetypes": [
            "application\/vnd.oasis.opendocument.text",
            "application\/vnd.oasis.opendocument.spreadsheet",
            "application\/vnd.oasis.opendocument.presentation",
            "application\/vnd.openxmlformats-officedocument.wordprocessingml.document",
            "application\/vnd.openxmlformats-officedocument.spreadsheetml.sheet",
            "application\/vnd.openxmlformats-officedocument.presentationml.presentation"
          ],

If the mimetype matches, we show the "open with collabora" menu entry.

@rullzer is this something we get directly from Collabora, or is this from our RichDocuments app?

tobiasKaminsky commented 5 years ago

https://collabora.server.com/hosting/discovery shows:

This XML file does not appear to have any style information associated with it. The document tree is shown below.
<wopi-discovery>
<net-zone name="external-http">
<app name="application/vnd.lotus-wordpro">
<action ext="lwp" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/svg+xml">
<action ext="svg" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-powerpoint">
<action ext="pot" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-excel">
<action ext="xla" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Writer documents  -->
<app name="application/vnd.sun.xml.writer">
<action ext="sxw" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.text">
<action ext="odt" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.text-flat-xml">
<action ext="fodt" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Calc documents  -->
<app name="application/vnd.sun.xml.calc">
<action ext="sxc" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.spreadsheet">
<action ext="ods" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.spreadsheet-flat-xml">
<action ext="fods" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Impress documents  -->
<app name="application/vnd.sun.xml.impress">
<action ext="sxi" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.presentation">
<action ext="odp" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.presentation-flat-xml">
<action ext="fodp" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Draw documents  -->
<app name="application/vnd.sun.xml.draw">
<action ext="sxd" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.graphics">
<action ext="odg" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.graphics-flat-xml">
<action ext="fodg" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Chart documents  -->
<app name="application/vnd.oasis.opendocument.chart">
<action ext="odc" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Text master documents  -->
<app name="application/vnd.sun.xml.writer.global">
<action ext="sxg" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.text-master">
<action ext="odm" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Math documents  -->
 <!--
 In fact Math documents are not supported at all.
         See: https://bugs.documentfoundation.org/show_bug.cgi?id=97006
    <app name="application/vnd.sun.xml.math">
            <action name="view" ext="sxm"/>
        </app>
    <app name="application/vnd.oasis.opendocument.formula">
            <action name="edit" ext="odf"/>
        </app>

-->
 <!--  Text template documents  -->
<app name="application/vnd.sun.xml.writer.template">
<action ext="stw" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.text-template">
<action ext="ott" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Writer master document templates  -->
<app name="application/vnd.oasis.opendocument.text-master-template">
<action ext="otm" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Spreadsheet template documents  -->
<app name="application/vnd.sun.xml.calc.template">
<action ext="stc" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.spreadsheet-template">
<action ext="ots" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Presentation template documents  -->
<app name="application/vnd.sun.xml.impress.template">
<action ext="sti" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.presentation-template">
<action ext="otp" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Drawing template documents  -->
<app name="application/vnd.sun.xml.draw.template">
<action ext="std" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.graphics-template">
<action ext="otg" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Base documents  -->
<app name="application/vnd.oasis.opendocument.database">
<action ext="odb" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Extensions  -->
<app name="application/vnd.openofficeorg.extension">
<action ext="oxt" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  MS Word  -->
<app name="application/msword">
<action ext="doc" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/msword">
<action ext="dot" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  MS Excel  -->
<app name="application/vnd.ms-excel">
<action ext="xls" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  MS PowerPoint  -->
<app name="application/vnd.ms-powerpoint">
<action ext="ppt" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  OOXML wordprocessing  -->
<app name="application/vnd.openxmlformats-officedocument.wordprocessingml.document">
<action ext="docx" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-word.document.macroEnabled.12">
<action ext="docm" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.openxmlformats-officedocument.wordprocessingml.template">
<action ext="dotx" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-word.template.macroEnabled.12">
<action ext="dotm" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  OOXML spreadsheet  -->
<app name="application/vnd.openxmlformats-officedocument.spreadsheetml.template">
<action ext="xltx" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-excel.template.macroEnabled.12">
<action ext="xltm" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.openxmlformats-officedocument.spreadsheetml.sheet">
<action ext="xlsx" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-excel.sheet.binary.macroEnabled.12">
<action ext="xlsb" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-excel.sheet.macroEnabled.12">
<action ext="xlsm" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  OOXML presentation  -->
<app name="application/vnd.openxmlformats-officedocument.presentationml.presentation">
<action ext="pptx" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-powerpoint.presentation.macroEnabled.12">
<action ext="pptm" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.openxmlformats-officedocument.presentationml.template">
<action ext="potx" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-powerpoint.template.macroEnabled.12">
<action ext="potm" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
 <!--  Others  -->
<app name="application/vnd.wordperfect">
<action ext="wpd" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-aportisdoc">
<action ext="pdb" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-hwp">
<action ext="hwp" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.ms-works">
<action ext="wps" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-mswrite">
<action ext="wri" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-dif-document">
<action ext="dif" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="text/spreadsheet">
<action ext="slk" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="text/csv">
<action ext="csv" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-dbase">
<action ext="dbf" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.lotus-1-2-3">
<action ext="wk1" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/cgm">
<action ext="cgm" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/vnd.dxf">
<action ext="dxf" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/x-emf">
<action ext="emf" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/x-wmf">
<action ext="wmf" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/coreldraw">
<action ext="cdr" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.visio2013">
<action ext="vsd" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.visio">
<action ext="vss" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-mspublisher">
<action ext="pub" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-sony-bbeb">
<action ext="lrf" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-gnumeric">
<action ext="gnumeric" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/macwriteii">
<action ext="mw" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-iwork-numbers-sffnumbers">
<action ext="numbers" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.oasis.opendocument.text-web">
<action ext="oth" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-pagemaker">
<action ext="p65" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/rtf">
<action ext="rtf" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="text/rtf">
<action ext="rtf" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="text/plain">
<action ext="txt" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-fictionbook+xml">
<action ext="fb2" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/clarisworks">
<action ext="cwk" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.corel-draw">
<action ext="cdr" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/x-wpg">
<action ext="wpg" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/prs.plucker">
<action ext="pdb" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-iwork-pages-sffpages">
<action ext="pages" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.openxmlformats-officedocument.presentationml.slideshow">
<action ext="ppsx" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-iwork-keynote-sffkey">
<action ext="key" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-abiword">
<action ext="abw" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/x-freehand">
<action ext="fh" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.palm">
<action ext="pdb" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.sun.xml.chart">
<action ext="sxs" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.sun.xml.writer.web">
<action ext="stw" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/x-t602">
<action ext="602" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/vnd.sun.xml.report.chart">
<action ext="odc" name="edit" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/bmp">
<action ext="bmp" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/png">
<action ext="png" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/gif">
<action ext="gif" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/tiff">
<action ext="tiff" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/jpg">
<action ext="jpg" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="image/jpeg">
<action ext="jpeg" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="application/pdf">
<action ext="pdf" name="view" urlsrc="https://collabora.server.com/loleaflet/bdf2f61/loleaflet.html?"/>
</app>
<app name="Capabilities">
<action ext="" name="getinfo" urlsrc="https://collabora.server.com/hosting/capabilities"/>
</app>
</net-zone>
</wopi-discovery>

So here are the extensions listed…

rullzer commented 5 years ago

This seems to be hardcoded... @juliushaertl do you know if we actaully do this dynamically in the app itself?

e-alfred commented 5 years ago

Is it possible to force the Android app to show the "Open with Collabora" menu option if a compatible file mimetype/file extension is detected?

tobiasKaminsky commented 5 years ago

@e-alfred what do you mean with force the app? As said, we rely on server which mimetype/files are compatible. And this seems to give us too few mimetypes. I do not want to maintain a supported list on android by its own.

juliushaertl commented 5 years ago

Yes, we currently hardcode those, but since Collabora is exposing the supported mimetypes, we should make sure to also expose those via the capabilities.

We also have a separate list of mimetypes that is used to register the viewer in the files web app, so maybe the reason was to avoid having to load the data from the collabora server before the document is even opened. I'll look into if we can make this more dynamic.

tobiasKaminsky commented 5 years ago

Cool, from the list by collabora we should focus on those mimetypes that are editable (name="edit") and not (name="view") as this is too much.

e-alfred commented 5 years ago

@tobiasKaminsky As far as I saw the default opening mode is just view-only and by tapping the edit button it switches to edit mode? Wouldn't it be good to have the ability to open all filetypes supported by Collabora and only leaving away the edit button on those which are view-only?

This would make the Nextcloud Android client far more usable if it would be able to open and view a lot more filetypes without the need to install additional apps on the client device.

Bubu commented 5 years ago

Where should this "Open with Collabora" menu entry be? I uploaded a .docx file from the android app and never got any option to open it with collabora anywhere.

My last-ditch workaround was making a link-share of it and opening that in my mobile-browser. That's a rather awkward solution though.

bold-gman commented 5 years ago

For my setup the menu entry "Open with Collabora" is very unreliable. Somestimes it shows up for .docx, .xlsx and the likes, sometimes it's just missing. It also differs from user to user, some can work with it, others have never seen the option. I have tried 3.5.0 and 3.5.1 RC on different phones (Android 8.0 and 8.1) but no noticable change, can't establish a pattern.

Deleting app caches and reinstallatin the app did not help either.

tobiasKaminsky commented 5 years ago

@Bubu @bold-gman currently we show/use collabora only for this mimetypes:

"richdocuments": {
          "mimetypes": [
            "application\/vnd.oasis.opendocument.text",
            "application\/vnd.oasis.opendocument.spreadsheet",
            "application\/vnd.oasis.opendocument.presentation",
            "application\/vnd.openxmlformats-officedocument.wordprocessingml.document",
            "application\/vnd.openxmlformats-officedocument.spreadsheetml.sheet",
            "application\/vnd.openxmlformats-officedocument.presentationml.presentation"
          ],

We plan to extend the supported mimetypes to match the behaviour of web ui: https://github.com/nextcloud/richdocuments/blob/master/js/viewer/viewer.js#L23-L54

This will be done by @juliushaertl. It needs only to be done on richdocuments app and with their new release it will work on all clients.

Bubu commented 5 years ago

@tobiasKaminsky Well, my document already should fall under the working category:

$ mimetype document.docx 
document.docx: application/vnd.openxmlformats-officedocument.wordprocessingml.document
tobiasKaminsky commented 5 years ago

Hm. We are getting the mimetype from server, maybe this file is identified in a different way on server. (btw: what command is mimetype?) Can you share this file with me? Just remove the content, but please keep the file and extension.

bold-gman commented 5 years ago

That's my problem as well. Editing docx and xlsx did work yesterday, but it's gone completey for the same files today. On a friend's device the menu option never showed up for the supported file types in the first place.

Bubu commented 5 years ago

(btw: what command is mimetype?)

Something I found lying around on my linux distro :)

$ apt-file search $(which mimetype)
libfile-mimeinfo-perl: /usr/bin/mimetype
[...]
Description-en: Perl module to determine file types
 File::MimeInfo can be used to determine the mime type of a file. It tries to
 implement the freedesktop specification for a shared MIME database.
 .
 This package also contains two related utilities:
  * mimetype: determine a file's mimetype
  * mimeopen: open files according to their mimetype

Here's the emptied file: https://cloud.bubu1.eu/s/RxbymF6JQ7CcMFi

bold-gman commented 5 years ago

And now the option is back. I haven't touched anything in the android app or on the server in the last two hours since the last post.

juliushaertl commented 5 years ago

As discussed with @tobiasKaminsky last week, ~this will be fixed in richdocuments, so I'm closing this in favor of https://github.com/nextcloud/richdocuments/issues/457~

juliushaertl commented 5 years ago

Ah sorry, confused the issues, this one of course needs some fixes in the android app, after https://github.com/nextcloud/richdocuments/issues/456 is done.

tobiasKaminsky commented 5 years ago

Android should hopefully automatically fetch and use them. Let's see ;-)

tobiasKaminsky commented 5 years ago

This should be resovled via new Collabora 3.3.0 app. Can you all test it?

Bubu commented 5 years ago

Updated to richdocuments 3.3.1, still the same behaviour for me.

tobiasKaminsky commented 5 years ago

In this case, this was missing:

  ProxyPass /hosting/capabilities https://127.0.0.1:9980/hosting/capabilities retry=0
   ProxyPassReverse /hosting/capabilities https://127.0.0.1:9980/hosting/capabilities

To further verify, you can go to https://$collabora-server/hosting/capabilities and see if "hasMobileSupport" is true.

Bubu commented 5 years ago

Nextcloud still caches the old non-existing capabilities file server-side. Changing the collabora server url to something else and then back was necessary to finally make this work. :+1:

@tobiasKaminsky Thanks for you help debugging this.

tobiasKaminsky commented 5 years ago

A little background: this was a breaking change with Collabora 4.0, and is now correctly reflected in docs.

z3dx95g7 commented 5 years ago

Nextcloud still caches the old non-existing capabilities file server-side. Changing the collabora server url to something else and then back was necessary to finally make this work. 👍

@tobiasKaminsky Thanks for you help debugging this.

i was trying to fix this for well over an hour, not understanding why everyone else seemed to have it working with the hosting/capabilities fix alone (which i truly wish was better documented itself... i bet most of us were getting incomplete info from here because it's not in collabora or nextcloud docs?). your comment finally fixed it for me on android. all the while it always worked fine on iOS... so thanks!

tobiasKaminsky commented 5 years ago

https://nextcloud.com/collaboraonline is the place to look at :-) If there is an error, please ping us

Bubu commented 5 years ago

https://nextcloud.com/collaboraonline is the place to look at :-)

That actually links to https://icewind.nl/entry/collabora-online/ for nginx instructions. Which are now outdated it seems.

tobiasKaminsky commented 5 years ago

I opened up an issue for our website.