Settings: show if daily backup is configured without going into backup settings

[natrius]

Actual behaviour

Opening settings, reading "Safe contacts Daily backup from your contacts"

Thinking "oh nice, automatic backups already set up, sweet."

After clicking it "Automatic backup: deactivated Last backup: never"

A friend deleted his contacts and i remembered there is this settings. This was actually my thought process and was already happy we can restore his contacts. Turns out - no.

Expected behaviour

When automatic backups are not set up write in the settings itself something like "Safe contacts Not set up yet" After done a manual backup is done write "Safe contacts Manual backup dd-mm-yyyy" And after the automatic backup is set up "Safe contacts Daily backup from your contacts"

Environment data

Android version: 8.1 Device model: OnePlus 3 Stock or customized system: LineageOs Nextcloud app version: 3.6.0 Nextcloud server version: 15.1

[stale[bot]]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[natrius]

Is there anything needed for the issue? Its really misleading to have it this way and it would just be some text changes...

[natrius]

@tobiasKaminsky is it possible to reopen the issue? I still think this is a problem.

[AndyScherzinger]

@tobiasKaminsky can you comment on this matter? :)

[stale[bot]]

This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[natrius]

If anything needed, i am happy to provide more information. Other than that, this post is just this issue does not cloce because i think its a small but important change.

[tobiasKaminsky]

@jancborchardt do you have an idea how to name this better? Same with davx5, we do not indicate if it is enabled/set up, so I think we do not need it here, but should make more clear that initial set up is required.

@natrius as the function itself is working, it is not a bug, but something we can and should enhance on a UI/UX level. (changing the label also prevents bot to close it)

[jancborchardt]

I’d say it’s simply a wording fix of the initial label to:

Back up contacts Set up automatic backup

[natrius]

I suggested UI changes in my initial post as well. Sorry about the "bug" tag, you are correct, @tobiasKaminsky

Backups not set up

Back up contacts
Not set up yet

After done a manual backup is done write

Back up contacts
Manual backup dd-mm-yyyy

And after the automatic backup is set up

Back up contacts
Daily backup from your contacts

EDIT: Thanks @jancborchardt for pointing that out, changed it. Thought its always "Backup" :)

[jancborchardt]

Good suggestions @natrius! One nitpick: "Back up" as in the verb are 2 words. :) Or we write "Contacts backup".

[neufeind]

Wondering about the app-data-size of my nextcloud-app I found there is a hidden folder (starts with a dot) named .Contact-Backups. That contains one contact-file for each day - for the last 2 years meanwhile. But that foldern does not appear to be synced? I also can't select it for sync since it stars with a dot (hidden). How is this supposed to work? Only with the additional caldav-client-configuration? How about simply uploading those files as a file-backup to the server, maybe with the option for "upload and delete here"?

[AlvaroBrey]

This was fixed when #9015 was implemented

[natrius]

I checked and nope. Its definitely not fixed. When opening setting its now

Contacts & calendar backup
Daily backup of your calendar & contacts

When opening this setting, nothing is checked. When checking everything, nothing changes to the initial text. Its still " *looking at the settings and reading 'Daily backup of your calendar & contacts' is set up, nice". Not everybody will checkthat setting with that wording.

Backups not set up

Contacts & calendar backup
Not set up yet

After done a manual backup is done write

Contacts & calendar backup
Manual backup dd-mm-yyyy

And after the automatic backup is set up

Contacts & calendar backup
Daily backup from your contacts & calendar

Or if you wanna stay static, change the wording to

Contacts & calendar backup
Create a manual backup or set up the automatic daily backup

You show with "Syn calendar & contacts" that the text can be longer. But this version does not imply its already set up. Please reopen that issue :)

[AlvaroBrey]

Hm, yeah, I misunderstood the point of the original issue.

I don't think it's a good idea to have that amount of states (and also complicates the logic). I would rather go for 2 states: "Daily backup not set up" and "Daily backup set up: (calendar/contacts/calendar & contacts)"

[tobiasKaminsky]

Then we can and should apply the same logic to auto upload: "auto upload not set up" "auto upload set up with x folders"