nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.07k stars 1.74k forks source link

In gridview show thumbnail and file name of video files #490

Open kollix opened 7 years ago

kollix commented 7 years ago

Actual behaviour

In the main view (all files) in grid mode I see thumbnails for images, I see a "note" image and the file name for a sound file, but for video files I see nothing but an "arrow" icon.

Expected behaviour

Preferred solution: Show any frame image from the video as thumbnail Alternative solution: show at least also the file name

Environment data

Android version: 4.4.2

Device model: Samsung Galaxy S4 mini

Stock or customized system: stock

Nextcloud app version: 1.4.0

Nextcloud server version: owncloud 8.2

tobiasKaminsky commented 7 years ago

This depends on your server configuration. You can enable a video preview generator.

mario commented 7 years ago

@tobiasKaminsky videos should still have a filename underneath them imho.

tobiasKaminsky commented 7 years ago

With our new #567 Photo view we can have both, I think:

cc @eppfel @jancborchardt

eppfel commented 7 years ago

mh, videos are not as easy to discover than images, because they have 3 dimensions and a thumb only 2. So i think it is a good idea to add the video filename. But I don't know of a visually appealing solution for that.

A gif preview would be awesome 😍

jancborchardt commented 7 years ago

Yeah … videos should ideally not have a name either, it's mostly as useless as the names of photos.

Only a "video" icon on them (check how Instagram does it, you can use the video.svg icon from the server), and ideally an animated preview of 3 or 5 frames of different sections of the video.

tobiasKaminsky commented 7 years ago

Only a "video" icon on them (check how Instagram does it, you can use the video.svg icon from the server)

We have this already. If the server supports video preview we have an image with a "play" icon on it.

jancborchardt commented 7 years ago

So on Nextcloud 11+ (or which version) this issue does not occur? Cause I just saw the issue was reported with 8.2 which is pretty outdated.

tobiasKaminsky commented 7 years ago

It depends if the server supports video previews as we rely on their preview API. (but then it already worked back in oC days)

jancborchardt commented 7 years ago

So maybe enabling previews for video files is something for the "Tips & tricks" section of the server? cc @rullzer @icewind1991

tobiasKaminsky commented 7 years ago

So what to do now?

jancborchardt commented 7 years ago

If we detect the server does not support video previews, show the video filetype icon as placeholder, instead of the play icon - and also the filename underneath. But no filename if the video preview image can be shown. :)