nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.32k stars 1.78k forks source link

Switch for in-app webview (help, etc) #691

Open mario opened 7 years ago

mario commented 7 years ago

There should be a switch that would force opening of URLs (help and other, custom URLs) inside an internal webview rather than opening a browser.

cc @jancborchardt @tobiasKaminsky @AndyScherzinger

AndyScherzinger commented 7 years ago

That would be best, yes. As for links do you mean the ones that might come in via the main menu extension or clicking on any kind of URL file which might be in your Nextcloud storage since for the later I'd say we should still give the user the choice to decide if he/she wants to go for their favorite browser or open it in-app (because with other apps like linkedin and xing, the in-app browser is rather pissing me off since I can't use my bookmarking service or other plugin apps...).

mario commented 7 years ago

I mean the following:

mario commented 7 years ago

As for files that you have, I'd still prefer to let the user choose rather than an internal webview.

AndyScherzinger commented 7 years ago

✔️ links inside the settings (see second point) ✔️ custom sidebar links (that come in via an app installed on the server) ✔️ custom storage link that goes below the quota bar

as for the last one, we do have links below the quota bar?

As for files that you have, I'd still prefer to let the user choose rather than an internal webview.

đź‘Ť sweet!

mario commented 7 years ago

It will be a customer specific link, we currently dont afaik.

tobiasKaminsky commented 7 years ago

Is it necessary to force this? If possible, I would use the "android way" and let the user decide between

This will be shown on the very first time an user clicks on an url.

Edit: ...and then there must be a way to change it. So...settings is right. But maybe as an enhancement for the user additionally show it in the above way?

mario commented 7 years ago

The user (in our app) will (for now) just use default external browser (maybe we can improve on this later). For the customer, yes, we need to force it.

jancborchardt commented 7 years ago

So, how about we do it »The Android Way« as @tobiasKaminsky described it in the normal app? And additionally there’s a branding option by which it can be forced to open all these links internally.

There should definitely be no settings switch called »open links in internal or external browser«. It’s something you decide the first time or on a case-by-case basis – as intended by Android.