nextcloud / android

📱 Nextcloud Android app
https://play.google.com/store/apps/details?id=com.nextcloud.client
GNU General Public License v2.0
4.14k stars 1.75k forks source link

Cannot get rid of file upload conflict notification #7905

Open jdaviescoates opened 3 years ago

jdaviescoates commented 3 years ago

Steps to reproduce

  1. Get a notification like this

Screenshot_20210128-155456

  1. Click it and end up at a dialog like this:

Screenshot_20210128-120617

  1. Whatever I do (choose original file, choose the new file, or cancel) doesn't make any difference, within a minutes or so (or even less) I get the exact same notification about the exact same conflict again. Again, and again, and again

Expected behaviour

Actual behaviour

Environment data

Android version:

8.1.0

Device model:

Wileyfox Swift 2 Plus

Stock or customized system:

Stock

Nextcloud app version:

3.14.3

Nextcloud server version:

20.0.6

Reverse proxy:

?

dremerb commented 3 years ago

Can confirm this behavior. For me this happened after restoring a backup and re-syncing - I have set all folders to "Skip uploading" (not sure about the correct name, German system here) and the last conflict remains in the notifications. Even after restarting the device, the sync starts again and the notification reappears.

jdaviescoates commented 3 years ago

I finally managed to get rid of the incessant notifications but selecting both files.

Klemens2 commented 3 years ago

I have the same problem very often too.

tobiasKaminsky commented 3 years ago

What kind of file is this? Does it come via auto upload?

Klemens2 commented 3 years ago

File types are: pictures (JPG) and videos (MP4).

Yes, it’s a matter of auto-upload (camera-upload).

Von: Tobias Kaminsky notifications@github.com Gesendet: Donnerstag, 25. Februar 2021 08:50 An: nextcloud/android android@noreply.github.com Cc: Klemens2 klemens.heuboeck@gmx.at; Comment comment@noreply.github.com Betreff: Re: [nextcloud/android] Cannot get rid of file upload conflict notification (#7905)

What kind of file is this? Does it come via auto upload?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nextcloud/android/issues/7905#issuecomment-785694421 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKGZZJ6WICG27VRQBIP25TTAX6JPANCNFSM4WXK33JA . https://github.com/notifications/beacon/AKKGZZN42PEI7U5JOTQSRT3TAX6JPA5CNFSM4WXK33JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF3KL5VI.gif

dremerb commented 3 years ago

When trying to get it working again, I encountered the following: Deleted all of the existing files in Nextcloud. NC client on Android still had sync activated. Uploaded images from Android to NC (auto upload does not do this automatically). Instant conflicts.

Also, often NC client on Android fails to build the conflict dialog (Message along those lines in a Toast).

wknds commented 3 years ago

I experience the same issue on an autoupload folder. I am working on Nextcloud android client 3.15.0 I thought this issue has been resolved in some older version of the client (https://github.com/nextcloud/android/issues/7082)

tobiasKaminsky commented 3 years ago

I use the app for auto upload also on daily base for my own purposes, but I never managed to create such a conflict problem when using auto upload. Even when I create manually a conflict, I can see conflict dialog just fine.

Do you have reliable steps how to reproduce this? Also on other devices? Otherwise I am currently out of clue how to debug this :/

wknds commented 3 years ago

In my case, i am syncing the folder Screenshots with Nextcloud. Let say the folder is synced. Now i am using a file browser and upload an already synced file to the folder Screenshot on Nextcloud. The issue from above appears. (Nextcloud android client 3.15.0). Can anybody confirm this?

Klemens2 commented 3 years ago

The syncing problem appears on my phone (Fairphone 2, android 7) as well as on the mobile of my wife (Xperia Z3+, android 5), in both cases when auto-uploading photos with last android app and NC 20.

Von: Tobias Kaminsky notifications@github.com Gesendet: Dienstag, 2. März 2021 10:15 An: nextcloud/android android@noreply.github.com Cc: Klemens2 klemens.heuboeck@gmx.at; Comment comment@noreply.github.com Betreff: Re: [nextcloud/android] Cannot get rid of file upload conflict notification (#7905)

I use the app for auto upload also on daily base for my own purposes, but I never managed to create such a conflict problem when using auto upload. Even when I create manually a conflict, I can see conflict dialog just fine.

Do you have reliable steps how to reproduce this? Also on other devices? Otherwise I am currently out of clue how to debug this :/

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nextcloud/android/issues/7905#issuecomment-788752863 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKGZZKY5WOYJCN3QFVQGGDTBSUAVANCNFSM4WXK33JA .

danielb7390 commented 3 years ago

I also get this problem with random files with the camera auto-upload feature.

tobiasKaminsky commented 3 years ago

From other issues I read that the problem might be that very big files are not uploaded in time (assembly on server takes some time, but client does not wait that long and thus it is marked as failed), and then the same file is tried to be uploaded again.

--> Is this only happening on large files?

Klemens2 commented 3 years ago

You might be right, because I remember, that often it have been video files, but I’m not sure, i fit were always big video files. I think, sometimes it has happened to pictures, too, but I‘ not sure.

Von: Tobias Kaminsky @.> Gesendet: Dienstag, 16. März 2021 08:15 An: nextcloud/android @.> Cc: Klemens2 @.>; Comment @.> Betreff: Re: [nextcloud/android] Cannot get rid of file upload conflict notification (#7905)

From other issues I read that the problem might be that very big files are not uploaded in time (assembly on server takes some time, but client does not wait that long and thus it is marked as failed), and then the same file is tried to be uploaded again.

--> Is this only happening on large files?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nextcloud/android/issues/7905#issuecomment-800016245 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKKGZZK2OYIZXMNX5C6PUZ3TD4AQTANCNFSM4WXK33JA . https://github.com/notifications/beacon/AKKGZZPAPE4C3CPK6Z6ZKS3TD4AQTA5CNFSM4WXK33JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOF6XUO5I.gif

danielb7390 commented 3 years ago

The last conflict i got yesterday it was a JPG file ~2MB

jdaviescoates commented 3 years ago

As per screenshots of my original post when this happened me the file was just 55kb. But eventually I checked both check boxes to keep both versions and it resolved itself (but there is actually only one version of the file on the server). It's not happened to be again since

dremerb commented 3 years ago

Finally had some time, tried to replicate. Android Client Version: 3.15.0 Server Version: 19.0.1

What has broken for me in the past: Had automatic backups running to replicate data from my phone to cloud. Broke Android one day (custom ROMs ftw -.-), downloaded all data from NC to desktop computer, loaded it to Android via USB. Then I rebuild the automatic upload structure, so all files that were copied manually to the phone should once again be synced to NC - to the locations I've just downloaded it from. This produced said error. Automatic upload was set to skip uploading, if a conflict occured, but this was ignored. Fix was (in this exact order!) to disable automatic upload, wipe data from cloud, re-setup automatic upload. There was no possible way to keep data in cloud and just setup NC on Android to use that folders again, always threw conflict messages.

What I've tried now: Created folder in webinterface, created new, empty local folder on Android. Loaded files into local folder on Android: synced as expected Loaded file to cloud via webinterface: showed in app on phone as expected. Loaded file to local folder on phone and immediately uploaded same file via webinterface: conflict in webinterface Loaded file to cloud via webinterface and immediately moved the exact same file to local folder on Android: conflict notification in app. Loaded file to cloud via webinterface and immediately moved the exact same file to local folder on Android with automatic backup set to skip files on conflict: no notification, seems to work as expected.

Conclusion: Can not replicate, although had the error earlier :/ Did no updates to NC server nor app since first occurence of the issue. All seems to be working as expected from my testing.

StephanRichter commented 3 years ago

Same problem here. Even files, for which I resolved the conflict months ago reappeared today. Now I have hundreds of conflicts.

7RST1 commented 3 years ago

I'm also having the same issue. I currently have 124 of these conflicts asking whether or not it should keep the identical file.

jdaviescoates commented 3 years ago

Just to say again, what resolved this for me was to check both check boxes to say I want to keep both versions of the file (although in the end I actually only ended up with one version of the file). It's not happened to me again since.

Klemens2 commented 3 years ago

Today, this worked for me too.

In the logs, i saw this entry (propably there is a connection to the problem)

Error no app in context Sabre\DAV\Exception\BadRequest: Expected filesize of 10240000 bytes but read (from Nextcloud client) and wrote (to Nextcloud storage) 9306112 bytes. Could either be a network problem on the sending side or a problem writing to the storage on the server side.

Klemens2 commented 3 years ago

Unfortunatly, the upload conflict notifications are back an my mobile. Around 10-20 each day. No entry (at all) in log.

github-actions[bot] commented 3 years ago

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

solarjoe commented 3 years ago

I have an issue that might be related to this one: https://github.com/nextcloud/android/issues/8653

Knusper commented 3 years ago

I also run into this.. and the notifications won't stop. It's the same file both on my device and the cloud - I tried to upload the same file twice via the share dialog from a sound recording app.

Selecting both files (instead of cancel) disabled the dialogue.

sbadger commented 3 years ago

I am seeing the same issue on my phone as well. In my case though I have 19 conflicts that wont go away and are not displayed in the app. I have tried cleaning the NC apps cache but that did not help. This has been going on for sometime though multiple updates in my case.

b-pfl commented 3 years ago

Slightly related to #7885

github-actions[bot] commented 2 years ago

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

dmrzzz commented 2 years ago

Thanks @jdaviescoates for the short-term workaround of selecting both file versions!

I still see this issue a lot, and am now wondering if my experience is being exacerbated by dueling auto upload rules. When I look under Settings > Auto upload, I have two separate occurrences of "Camera". One of them has a picture icon next to it, and the other one has a movie icon next to it, but when I ... > Configure each of them I see that they are both trying to upload /storage/emulated/0/DCIM/Camera to Remote folder /InstantUpload/Camera (all the other visible settings are likewise identical). I'm going to try disabling one of them and see if that reduces the number of conflicts while still successfully uploading both images and videos.

Are there supposed to be two auto upload rules for the same folder? Is the icon actually meaningful?

(update: it turns out that disabling the movie icon instance of "Camera" caused it to keep uploading pictures but stop uploading movies from that folder -- no help)

Klemens2 commented 2 years ago

I give up using autoupload function. Annoying. Last weeks, I tried to use it for a third person. I installed it to upload just when the phone is connected to power supply, that it should upload old pictures and to rename the files if there is a sync error. In fact, it didn't do any of these. It uploaded without connection to power supply, uploaded old files and showed the sync conflict dialogues. Really annoying, that for me this problems still remain evident and even are getting more/worse.

wknds commented 2 years ago

9036 contains a fix. So does #8923 with another concept for "keep server version".

github-actions[bot] commented 2 years ago

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

dmrzzz commented 2 years ago

@tobiasKaminsky it certainly seems plausible that this problem involves "retrying" uploads that were actually successful, either because the file is big or just because something else happens to go wrong. (speculation: perhaps you have trouble reproducing because your server / provider is too reliable? I'm using a free one)

If so, it seems like the solution might be #8948 (if existing remote file has same contents as local file, consider the file to be uploaded and do not create a conflict dialogue)

stratus-ss commented 2 years ago

I wanted to make sure that this issue stays open and that it is still active.

I have been having this problem for a while but today I actually couldnt get rid of the notifications unless I go into the app and actually delete the file and the upload task.

This is a very disappointing user experience. I would imagine (though I have no real data on this) that the primary reason to have the app on the phone is to sync/auto upload. To me this bug makes the app almost broken. I definitely have not been rolling it out for the users I support specifically because of this bug and the poor experience it brings

bryanpaget commented 2 years ago

I am also experiencing this. My photos are always uploaded but the app always complains.

AlvaroBrey commented 2 years ago

Partial fix in https://github.com/nextcloud/android/pull/9036 which will be hopefully merged soon. We're sorry for not dedicating more effort to this currently, but we are spread thin. Of course, PRs are always welcome.

yoru74 commented 2 years ago

I've just upgraded from NC 19 to 22 and this issue appeared. I think it comes from the server. Before uploading the file, the app does a "GET /remote.php/dav/files/.../your_file_to_be_uploaded In the old server version, this returns with a 404, in the new version it returns with 302 that redirects to the dashboard. I will try to fix the server side, as I have no access to the Android environment. On the app side, IMHO, 302 should be treated as 404.

yoru74 commented 2 years ago

I solved my own issue. In case it may help other people, here is what happened. I'm using nginx as web server. In the configuration example I used there was the line:

error_page 404 = /core/templates/404.php;

This results in a return value with code 302 instead of 404!

The easiest way to debug it was with curl, using the command: curl --user 'your_user:your_password' -X HEAD -v https://your.url.com/remote.php/dav/files/your_future_upload_file

sschleic commented 2 years ago

I'am using Nextcloud version 23. I checked the curl command. It is returning a 404 for new files. But I also get the conflict dialog pop up

Dulanic commented 2 years ago

Mine does this quite often and lately if I click on it, it doesn't give me a option to pick and nothing is uploaded.

tobiscode commented 2 years ago

Hi everyone,

for what it's worth, unsolvable file resolution conflicts also happen on a fresh phone. I migrated all my data from a Pixel 2 XL (Android 11) to a Pixel 6 (Android 12) (via a cable during phone setup) and then installed Nextcloud 3.17.1. It wanted to reupload every file I had ever put in an auto-upload folder, even though according to the file conflict notification, they are the same files. (To be clear, not a single file should be uploaded from the new phone, since I copied over the files to the new phone from the old one, and they should therefore be the exact same files as were uploaded to NC earlier.) I disabled all auto sync (since I don't want to click on 2k+ notifications) and hope this issue will get fixed soon - not sure if it's related to the linked PR. (I didn't try 3.18.x since back on my Pixel 2 XL, 3.18.x gave me the problems described in here: https://github.com/nextcloud/android/issues/9328)

Even worse, now that I have disabled all auto-sync, when opening the Nextcloud app, I still get all the "unsolved" file conflict notifications, so I can't use the app anymore at all.

Thanks for looking into this!

Edit: Maybe relevant, on my PIxel 2 XL, I used Google Store to download the app, and on the Pixel 6, I use F-Droid (which I prefer anyway, but mostly because it gave me access to the non-bugged 3.17.x version). Maybe there's an issue with signatures?..

Der-Zohan commented 2 years ago

I have this issue also for every file I'm uploading. Running NC23 on Ubuntu Server 20.04 with Apache.

NC client running on Android 11.

Hope there will be a solution soon.

zsolt-donca commented 2 years ago

I still have the same issue despite having received the 3.19.0 update from F-Droid a few days ago. No matter what I chose, the conflict reappears.

I've had high hopes for the fix of this bug, as used to have the issue before the update as well, and I've practically been living with 48 such notifications for months now.

AlterDepp commented 2 years ago

Same for me. Version 3.19.0 didn’t change anything. Can we reopen this issue?

Dulanic commented 2 years ago

Same for me. Version 3.19.0 didn’t change anything. Can we reopen this issue?

Same for me. I had 45 notifications I could not clear until I deleted the uploads. Conflict resolution is deff not fixed.

sschleic commented 2 years ago

I cant geht rid of it. One Detail in my Case: i'am only getting the conflict Pop Up when auto auploading to a shared folder I'am not the owner of it. Uploading to my own folder ist fine.

Dulanic commented 2 years ago

I cant geht rid of it. One Detail in my Case: i'am only getting the conflict Pop Up when auto auploading to a shared folder I'am not the owner of it. Uploading to my own folder ist fine.

That might be a good catch, mine is also shared. Though I am the owner of it.

Der-Zohan commented 2 years ago

I have this problem as well. Using version 3.19.1 RC2

newts commented 2 years ago

In addition to the same problem as others I just found Nextcloud used 30GB of mobile data in the last few weeks. This really needs to be fixed to make Nextcloud usable on mobile devices. LMK if I can help test a new version. I am using the /e/ server.

tobiscode commented 2 years ago

I have had this problem over the last couple of versions. The easiest way for me to reproduce the error is to have a clean install of Nextcloud, set up a folder to sync, with the only condition that both the phone and the server already have the same file present. If I then check the box to sync already existing items, the upload conflict notification appears, and it cannot be resolved. It keeps reappearing quite frequently, independently of whether I'm using the Nextcloud app or not. Deleting the autoupload folder doesn't help, cleaning the cache and force-quitting the app doesn't work, the only thing that removes the notification is to completely uninstall and reinstall the app.

Edit: looking at the other comments, I'm not uploading to a shared folder, deleting the uploads didn't help, but only uploading new files works for me.

rjDipcord commented 2 years ago

Leaving a comment to say that this issue is also happening to me and I am running a Samsung Galaxy Note 9 and Nextcloud android version 3.20.3. Using Nextcloud server 24.0.1. At this moment, it is even impossible to choose what to do with the notifications since I am getting a "Error creating conflict dialog!" message.