Crash when returning to UI a day later after playing video: NPE via `ExtendedListFragment.onCreateOptionsMenu`

zell-mbc commented 3 years ago

Steps to reproduce

Start app, navigate to video stored locally
Watch the video
Dont close the video but keep on doing other stuff
return to ui to watch another video (in my case a day later)
ui is showing still of previous video but is unresponsive and crashes eventually

Expected behaviour

Either show the Filesystem or continue with the old video

Actual behaviour

App crashes when trying to continue to play the video

Can you reproduce this problem on https://try.nextcloud.com?

Please create a test demo account and see if this still happens there.
If yes, please open up a bug report
If not, please verify server setup and ask for help on forum

Environment data

I'm using my tablet, will add these details later when at my PC Android version:

Device model:

Stock or customized system:

Nextcloud app version:

Nextcloud server version:

Reverse proxy:

Logs

Web server error log

Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

NOTE: Be super sure to remove sensitive data like passwords, note that everybody can look here! You can use the Issue Template application to prefill some of the required information: https://apps.nextcloud.com/apps/issuetemplate

AlvaroBrey commented 3 years ago

This looks like a duplicate of #8686, since it's still media player related. Can you try to get some logs, or reproduce it with the steps defined in #8686? (Play a short MP3 file until it ends, and then hit Back)

zell-mbc commented 3 years ago

Things reliably crashed for a while until I finally decided to log an error, but ever since I haven't seen another one? Maybe an update came along since, I can't remember. But given that things were working for a month now I think it's fair to close this issue for now. I can always reopen (with a proper log) in case it comes back again.

zell-mbc commented 3 years ago

Finally managed to grab the crash log:

**** CAUSE OF ERROR ****

java.lang.NullPointerException: Attempt to invoke interface method 'android.view.View android.view.MenuItem.getActionView()' on a null object reference
    at androidx.core.view.MenuItemCompat.getActionView(MenuItemCompat.java:188)
    at com.owncloud.android.ui.fragment.ExtendedListFragment.onCreateOptionsMenu(ExtendedListFragment.java:192)
    at androidx.fragment.app.Fragment.performCreateOptionsMenu(Fragment.java:3100)
    at androidx.fragment.app.FragmentManager.dispatchCreateOptionsMenu(FragmentManager.java:3181)
    at androidx.fragment.app.FragmentController.dispatchCreateOptionsMenu(FragmentController.java:391)
    at androidx.fragment.app.FragmentActivity.onCreatePanelMenu(FragmentActivity.java:288)
    at androidx.appcompat.view.WindowCallbackWrapper.onCreatePanelMenu(WindowCallbackWrapper.java:94)
    at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.onCreatePanelMenu(AppCompatDelegateImpl.java:3084)
    at androidx.appcompat.view.WindowCallbackWrapper.onCreatePanelMenu(WindowCallbackWrapper.java:94)
    at androidx.appcompat.app.ToolbarActionBar.populateOptionsMenu(ToolbarActionBar.java:456)
    at androidx.appcompat.app.ToolbarActionBar$1.run(ToolbarActionBar.java:57)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:999)
    at android.view.Choreographer.doCallbacks(Choreographer.java:797)
    at android.view.Choreographer.doFrame(Choreographer.java:728)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:984)
    at android.os.Handler.handleCallback(Handler.java:883)
    at android.os.Handler.dispatchMessage(Handler.java:100)
    at android.os.Looper.loop(Looper.java:237)
    at android.app.ActivityThread.main(ActivityThread.java:8107)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

**** APP INFORMATION **** ID: com.nextcloud.client Version: 30170090 Build flavor: generic

**** DEVICE INFORMATION **** Brand: samsung Device: gts4lwifi Model: SM-T830 Id: QP1A.190711.020 Product: gts4lwifixx

**** FIRMWARE **** SDK: 29 Release: 10 Incremental: T830XXU5CUE2 ` Same situation again:

returned to the nextcloud client
Video was still playing / started again from two days ago
I think I pressed the back arrow
Crash

nextcloud / android