nextcloud / announcementcenter

šŸ“¢ Announcement Center for Nextcloud
https://apps.nextcloud.com/apps/announcementcenter
GNU Affero General Public License v3.0
39 stars 24 forks source link

Announcements are always shown twice in notifications #781

Open jancborchardt opened 7 months ago

jancborchardt commented 7 months ago

Steps to reproduce

  1. Admin makes an announcement
  2. Open notification box

Expected behaviour

Only 1 notification per announcement.

Actual behaviour

2 notifications per announcement: image

Server configuration

Current cloud.nc

Client configuration

Browser: Firefox 123.0

Operating system: Ubuntu 22.04.4

jancborchardt commented 7 months ago

Seems this is the same as https://github.com/nextcloud/announcementcenter/issues/637 ?

For "An announcement is posted by an administrator" push was still enabled. I disabled it now, but I would assume that if it's enabled I get 1 notification, and if I disable it I see nothing at all.

nickvergessen commented 7 months ago

but I would assume that if it's enabled I get 1 notification, and if I disable it I see nothing at all.

No, that is for activities. Notifications and activities are admin options while posting. You basically enabled to get the activity mirrored into your notifications.

I will try to prevent this by forcing the push setting to off

SimJoSt commented 2 months ago

We believe we ran into the same issue. Our process was like this:

  1. Started creating an announcement
  2. Disable creating a notification for the announcement
  3. Create the announcement

Some users still received a "notification" email about the announcement, which was not our intention. They also received push notifications about the announcement.

Going through all the settings in our Nextcloud instance, I believe 2 settings were responsible for this:

This led to nearly all users receiving a push notification for the announcement activity, even though the admin creating the announcement didn't intend on anyone receiving a notification, and the notification email reminder caused a second wave of email notifications 1 week later for a lot of users.

We solved our own issues by adjusting these default settings as well as the settings of users directly.

I suggest the following changes:

I'm not sure what other changes, if any, should be made to the current system. Maybe adjusting the wording could already suffice. Admins should be aware that creating announcements without enabling the "Create notifications" option, could still notify users, depending on the Activity settings. It should be clear which setting is overwriting which other setting.

Possible changes:

SimJoSt commented 2 months ago

Reading through this https://github.com/nextcloud/announcementcenter/issues/637 I realize I don't know if the "Create notifications" option is only creating a push notification or is sending emails as well. If the latter is the case, my previous comment and suggestions would slightly differ.