search

nextcloud / ansible-collection-nextcloud-admin

The ansible galaxy for your nextcloud administrative needs.
https://galaxy.ansible.com/nextcloud/admin
BSD 2-Clause "Simplified" License
138 stars 77 forks source link

Temporary ignore ansible-lint var-naming[no-role-prefix] #276

Closed staticdev closed 1 year ago

staticdev commented 1 year ago

This error started with last update of ansible-lint. It triggers more than 80 errors. I am adding this ignore until we fix it.

staticdev commented 1 year ago

LGTM but do we need to fix it ? smile I suppose It will come down to ansible galaxy linter that'll impact the collection stars level

I am pretty sure Galaxy does not update ansible-lint as fast as we do. But yes we should fix, I can do that soon. For now it will avoid annoying emails in our inboxes. Could you approve again? I did a failed test to fix.

aalaesar commented 1 year ago

LGTM but do we need to fix it ? smile I suppose It will come down to ansible galaxy linter that'll impact the collection stars level

I am pretty sure Galaxy does not update ansible-lint as fast as we do. But yes we should fix, I can do that soon. For now it will avoid annoying emails in our inboxes. Could you approve again? I did a failed test to fix.

Actually, It reminds me of the issues I got with pre-commit hooks: #207 that got fixed with a simple update some tests seems to be related to ansible lint version and maybe are disabled later. IMHO, this lint rule seems pretty arbitrary. I mean , enforcing naming convention of variable is pretty invasive and a very opiniatred rule (that some may want to apply)

I expect it to be disabled in a future version but for now we will deal with it with the lint ignore

staticdev commented 1 year ago

LGTM but do we need to fix it ? smile I suppose It will come down to ansible galaxy linter that'll impact the collection stars level

I am pretty sure Galaxy does not update ansible-lint as fast as we do. But yes we should fix, I can do that soon. For now it will avoid annoying emails in our inboxes. Could you approve again? I did a failed test to fix.

Actually, It reminds me of the issues I got with pre-commit hooks: #207 that got fixed with a simple update some tests seems to be related to ansible lint version and maybe are disabled later. IMHO, this lint rule seems pretty arbitrary. I mean , enforcing naming convention of variable is pretty invasive and a very opiniatred rule (that some may want to apply)

I expect it to be disabled in a future version but for now we will deal with it with the lint ignore

Hopefully yes or all roles using it will have to change all task names (bit big effort if you sum up for a not so big improvement).