search

nextcloud / ansible-collection-nextcloud-admin

The ansible galaxy for your nextcloud administrative needs.
https://galaxy.ansible.com/nextcloud/admin
BSD 2-Clause "Simplified" License
138 stars 77 forks source link

Fix a bug in nc_apache2.j2 template concerning intermed-CA. Remove an… #280

Closed marioqxx closed 1 year ago

marioqxx commented 1 year ago

…sible-lint warnings and add config-variable needed for SSO to nc_apache2.j2 template. The diff in tls_signed.yml looks a bit wired, as the change involved swapping two tasks only and adding some "when" conditionals.

wiktor2200 commented 1 year ago

Hi! These changes for TLS certs looks good, but I think we shouldn't change mode to different notation. We should keep it consistent across the repository. So I suggest reverting mode changes.

staticdev commented 1 year ago

Hi! These changes for TLS certs looks good, but I think we shouldn't change mode to different notation. We should keep it consistent across the repository. So I suggest reverting mode changes.

I also prefer that the whole code has consistent modes, good point.

staticdev commented 1 year ago

@wiktor2200 @marioqxx after this one we can release 2.1.0 ;)

wiktor2200 commented 1 year ago

@marioqxx Approved and merged :) @staticdev we can proceed with the release I suppose ;)