search

nextcloud / ansible-collection-nextcloud-admin

The ansible galaxy for your nextcloud administrative needs.
https://galaxy.ansible.com/nextcloud/admin
BSD 2-Clause "Simplified" License
138 stars 77 forks source link

Fixes nginx conf file if using http (port 80) only #300

Closed YohannLYD closed 1 year ago

YohannLYD commented 1 year ago

The options _servername and root were missing in the nginx config file if one wants to install an instance only using port 80 (and let another remote reverse proxy deal with the ssl part for instance)

wiktor2200 commented 1 year ago

To have it merged, you need to sign off your commit and made DCO check passed.

To do that you have to rebase your commit for further details, please visit this link: https://github.com/nextcloud/ansible-collection-nextcloud-admin/pull/300/checks?check_run_id=15846042861 or click "Details" near DCO check icon.

wiktor2200 commented 1 year ago

@aalaesar @staticdev could you take a look? @YohannLYD I'm not 100% sure if fastcgi_param HTTPS $https if_not_empty; will work without setting it first. Have you tested that for https?

YohannLYD commented 1 year ago

I'm not 100% sure if fastcgi_param HTTPS $https if_not_empty; will work without setting it first. Have you tested that for https?

Yes, the server properly works in both cases (http and https) with this setting.

wiktor2200 commented 1 year ago

I've already tested and verified this config. I'm merging it. Thanks again @YohannLYD for your contribution! :)