Rename tasks to be closer to Ansible convention

nextcloud / ansible-collection-nextcloud-admin

The ansible galaxy for your nextcloud administrative needs.

https://galaxy.ansible.com/nextcloud/admin

BSD 2-Clause "Simplified" License

138 stars 77 forks source link

Rename tasks to be closer to Ansible convention #329

Closed l00ptr closed 9 months ago

l00ptr commented 10 months ago

We try to fix some (small) issues with tasks names and adapt them to respect (as much as possible) the recommended convention from ansible-lint and Ansible:

https://ansible.readthedocs.io/projects/lint/rules/name/

Basicly we:

Remove the useless "
Ensure all tasks names start with a Capital letter
Add a prefix for tasks within sub-tasks files
Avoid templating in tasks names
Try to use / favorise present-tense and imperative style

staticdev commented 10 months ago

If @aalaesar agrees, I am all in.

l00ptr commented 10 months ago

@aalaesar so what about the failing CI ? Can we / you merge that PR ?

staticdev commented 10 months ago

@aalaesar so what about the failing CI ? Can we / you merge that PR ?

I am trying to rerun.. we are fighting some flakyness on GA for some time in this repo, but all works good xD

staticdev commented 9 months ago

I see the errors we have are not related to the PR, and i created a new issue. No reason to wait longer. Thanks @l00ptr !