nextcloud / app_api

Nextcloud AppAPI
https://apps.nextcloud.com/apps/app_api
GNU Affero General Public License v3.0
81 stars 7 forks source link

Add possibility to edit Deploy daemon configuration #338

Closed vstelmakh closed 3 months ago

vstelmakh commented 3 months ago

Resolves #332

image

vstelmakh commented 3 months ago

Is there any reason for manual changes to l10n/*.js files? They are being updated automatically via Transifex (https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#adding-translations).

Thank you for bringing this to my attention. I had no idea about the update process for the translation files in this project. My intention was simply to improve the translations related to the change for the languages that I understand.

Should I revert the changes I made to the translation files?

Please let me know how I can best proceed to ensure everything remains consistent with the project's workflow.

bigcat88 commented 3 months ago

Should I revert the changes I made to the translation files?

Yes, please, revert the translation changes.

We try to avoid making changes to multiple topics in a single pull request to make them easier to review and keep the commit and discussion history cleaner.