search

nextcloud / app_api

Nextcloud AppAPI
https://apps.nextcloud.com/apps/app_api
GNU Affero General Public License v3.0
82 stars 7 forks source link

Added stopping of docker containers when ExApp is disabling. Timeout of enable/disable increased to 60. #430

Closed bigcat88 closed 3 weeks ago

bigcat88 commented 3 weeks ago

If ExApp is resource-heavy, stopping it now does not always free up resources (only if it is implemented in ExApp itself, which is quite rare)

That is why we add this PR to turn off the docker container when clicking the "disable" button on ExApp.

With "manual installation" - nothing changes, we have nothing to turn off and this is not supported.

Also, the timeout for a request to ExApp to turn on/off has been raised from 30 seconds to 60 seconds, which is still acceptable for UI so as not to seem slow;

Resolves: #410

bigcat88 commented 3 weeks ago

/backport to stable30

backportbot[bot] commented 3 weeks ago

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/430/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8b0c59e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/430/stable30

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress fatal: cherry-pick failed

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

bigcat88 commented 3 weeks ago

/backport to stable29

backportbot[bot] commented 3 weeks ago

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/430/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8b0c59e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/430/stable29

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress fatal: cherry-pick failed

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.