search

nextcloud / apps

🚚 This is an archive. Let us know if you want to take over maintainership of any of these apps
11 stars 29 forks source link

Add possibility to login with email on imap #41

Closed pierreozoux closed 6 years ago

pierreozoux commented 7 years ago

Fixes #40

It is my first php/Nextcloud PR, so be gentle :)

If you think we should put this behind an option, let me know. Also, you have to keep in mind that this will create an entry in user_external, but you'll still have to delete manually the uid in user entry if you are migrating from normal user to imap user (in reference to #34).

MorrisJobke commented 7 years ago

Makes sense. Sadly I cannot test this.

cc @rullzer and @icewind1991 for some feedback on this as well.

rullzer commented 7 years ago

Yes makes sense. but also I have no easy way to test this quickly.

pierreozoux commented 6 years ago

Do you think we could get this merged before Nc13 is released?

Thanks a lot!

umgfoin commented 6 years ago

@MorrisJobke As NC 13 release is approaching: Could somebody add a bug-label, here, otherwise commit f8fb4d9 will pass into stable breaking an official app in NC13 on Postgres.

Thanks, umgfoin.

MorrisJobke commented 6 years ago

As NC 13 release is approaching: Could somebody add a bug-label, here, otherwise commit f8fb4d9 will pass into stable breaking an official app in NC13 on Postgres.

🙈 Nobody really maintains this. And I totally have overseen that this is in our release :/

@rullzer @nickvergessen @icewind1991 Ideas?

umgfoin commented 6 years ago

Nobody really maintains this.

No worries, nearly maintenance-free, sofar ;-) PR pending - review required.

++umgfoin.