Remove old apps - Githubissues

MariusBluem commented 6 years ago

emoji (removed due native support in Nextcloud)
files_videoviewer (moved over to files_videoplayer)
imprint (moved to external & theming-app)
ownpad_lite (moved to ownpad community app & replaced by other notes-apps)
pushnotifications (is now integrated with other code)
reader (replaced by collabora, onlyoffice & documents - no development here)
tattoo (theming, unsplash, theming_customcss)
user_persona (persona was shut down by Mozilla in 2016)
user_saml (new app in separate repository)

Signed-off-by: Marius Blüm marius@lineone.io

jancborchardt commented 5 years ago

@MorrisJobke @rullzer what do you think?

jancborchardt commented 5 years ago

Btw, only user_external is not older than 2 years and that people contribute to. Should we move that one to a separate repository – then it doesn’t create the illusion any of these other apps are still maintained.

What do you think @MorrisJobke @rullzer?

MorrisJobke commented 5 years ago

Btw, only user_external is not older than 2 years and that people contribute to.

This is also fairy unmaintained. It is used by some people, but mostly only gets a version bump and not much testing. :(

jancborchardt commented 5 years ago

Yes, but separating that one semi-maintained app out and adding all the people to the repository would already be much better than having it rot in here. ;)

Contributors to the user_external app from the history are @tflidd @umgfoin @pierreozoux @MarvAmBass @kosli – if they would like to be maintainers we could simply do that. :slightly_smiling_face:

Or is it not intended to support the app further as there is a replacement?

MorrisJobke commented 5 years ago

Fine with me to extract it

violoncelloCH commented 5 years ago

@jancborchardt thank you for inviting me to be co-maintainer of user_external! I will think about it, but would need some more information on what it would mean exactly to be co-maintainer of the app...?

jancborchardt commented 5 years ago

@violoncelloch nothing more than you are comfortable with. :) Just making sure that fixes and pull requests other people make get merged, adjusted or you @-mention the right people, and that also it just gets upped for every new version. :) That’s the basics.

violoncelloCH commented 5 years ago

@jancborchardt That sounds doable :) I think you can count me in... For the @-mentions I think I still need to learn who is the right person for what, but that will come over time.

pierreozoux commented 5 years ago

Yes we still use IMAP for our user login, and happy to see somebody to step in as maintainer. We plan to switch to either saml or ldap in 2019. But yeah, we don't have enough php compétences to pretend to maintain it. And little financial resources to support :/

jancborchardt commented 5 years ago

@violoncelloCH there you go, I created https://github.com/nextcloud/user_external for the app. :) Also the group @nextcloud/user_external where I added the people who contributed to it in the past whom I mentioned above.

Let me know if that works or any further permissions are needed. :) @MorrisJobke @rullzer do we have some sort of best practice to move this app out of this big repository into its own? I guess there’s no way to preserve history so probably @violoncelloCH initially just copypastes it, correct?

MariusBluem commented 5 years ago

Could we then unbundle this app from the release binary and just move it into the app store - I mean: it is not usable with 15.0.0 for now anyway so we would not break something? 🤔

violoncelloCH commented 5 years ago

@MorrisJobke @rullzer do we have some sort of best practice to move this app out of this big repository into its own? I guess there’s no way to preserve history so probably @violoncelloCH initially just copypastes it, correct?

Is the history preserved if we move files inside of a repo? If so, we could copy/clone the whole repo and then remove all other apps and move user_external to the root...?

MariusBluem commented 5 years ago

https://github.com/nextcloud/apps/pull/69#issuecomment-448937195

MorrisJobke commented 5 years ago

Let me know if that works or any further permissions are needed. :) @MorrisJobke @rullzer do we have some sort of best practice to move this app out of this big repository into its own? I guess there’s no way to preserve history so probably @violoncelloCH initially just copypastes it, correct?

There is a git command to do this. It extracts the history of a sub directory. Just search for it in the internet. 😉

violoncelloCH commented 5 years ago

@MorrisJobke I found two ways to do something like that: https://help.github.com/articles/splitting-a-subfolder-out-into-a-new-repository/ (uses git filter-branch --prune-empty --subdirectory-filter) and https://stackoverflow.com/questions/359424/detach-move-subdirectory-into-separate-git-repository/17864475#17864475 (uses git subtree split). Which is the correct (/better) way to do it?

jancborchardt commented 5 years ago

@violoncelloCH maybe try both locally and see which one works better? Important thing to look for would also be that the repository size is not as big as the whole apps repo. :)

violoncelloCH commented 5 years ago

git filter-branch seems to work fine. Repo size 304K out of 420 MB for the apps repo. Only the master branch is kept.

jancborchardt commented 5 years ago

@violoncelloCH good stuff! Let me know if pushing to the new repo works fine or if you need anything! Thanks so much for taking care of this! :)

Also wow, the repo site reduction … this will make it so much simpler for people to contribute to the one still used app. :+1:

violoncelloCH commented 5 years ago

@jancborchardt pushing worked! hope it's all fine... I think we need to turn on branch protection for master now? Can you do this? I don't have access to the repo settings...

jancborchardt commented 5 years ago

@violoncelloCH done! :) Let’s continue in the repository then! :)

nextcloud / apps

Remove old apps #59