nextcloud / appstore

:convenience_store: App Store for Nextcloud
https://apps.nextcloud.com
GNU Affero General Public License v3.0
295 stars 138 forks source link

More detailed licensing information #1274

Open jorsn opened 9 months ago

jorsn commented 9 months ago

It would be helpful to include more detailed licensing information for all apps: E.g., AGPL-3.0-only or AGPL-3.0-or-later is a difference (I used spdx license codes, here).

See https://github.com/NixOS/nixpkgs/commit/c317dcec0d36ba6c51f73bd23b5425a3f1d03141 for an example where this creates problems. In NixOS, the purpose is to package the apps so that Nextcloud can be declaratively configured and automatically deployed with particular apps.

provokateurin commented 1 month ago

I was about to create a similar issue, the license field currently does not allow distinguishing AGPL-3.0-only and AGPL-3.0-or-later which is quite a problem.

@bigcat88 What do you think about moving to SPDX identifiers only and keeping the old values for compatibility? I don't think there is a way to really deprecate an enum value, but it should be removed eventually. I can create a PR for this, if this is the way to go.

bigcat88 commented 1 month ago

SPDX Identifiers is definitely the way to go, imho.

To make the transition simple, we can:

  1. just add a new field to info.xml which we'll call for example - and if it exists, take SPDX Identifiers from there. And for some time there will be two fields in parallel.

or

  1. Since SPDX Identifiers will start with "SPDX-License-Identifier" - can we add support for them directly to the app store in the current field? We'll have to rewrite it a bit and move away from enum as I understand it in this case - but it seems possible.
susnux commented 1 month ago

2. Since SPDX Identifiers will start with "SPDX-License-Identifier"

I think there is confusion about this: SPDX-License-Identifier is from REUSE while I think @provokateurin and @jorsn want to use SPDX license identifiers within the license field. So just some standardized identifiers for licenses, as currently agpl could mean anything, it does not have any license version information.

(BTW I would also love to see SPDX identifiers for license :sweat_smile: )

provokateurin commented 1 month ago

Exactly, this is about the appinfo.xml \ element