search

nextcloud / appstore

:convenience_store: App Store for Nextcloud
https://apps.nextcloud.com
GNU Affero General Public License v3.0
294 stars 138 forks source link

refactor(scaffolding): Migrate app template to Github template repo #1368

Closed provokateurin closed 5 months ago

provokateurin commented 5 months ago

As an alternative to downloading the zip on the fly the app_template repo could be added as a git submodule to pin a specific version to avoid unintended changes. This submodule would need to be updated at least once per server release which adds more work again (quite manageable though).

bigcat88 commented 5 months ago

Can we just redirect the user when clicking to start an automatic download via a redirect, will it be fine?

This will save us from adding caching of this, because in the current implementation, sending a download request and not caching the response will lead to a fairly simple opportunity to DDOS AppStore in some cases.

provokateurin commented 5 months ago

You are right, the problem is that it's not simply downloading and returning the zip file, but it replaces the content in some files so the values the user submitted are applied.