Shared Notes will be massivly checked by Bookmarks --> Tons of Activites

GAS85 commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

Install Notes and Bookmarks.
User A use Bookmarks. User B do not use Bookmarks at all.
User A: Create Category "TEST" in Notes. This will drive to Folder creation in /Notes/TEST
Share Folder /Notes/TEST with User B.
User B move shared folder from /TEST to /Notes/TEST, in this case shared notes will appears to the Notes App.
Create one - multiple Notes in TEST Category.
User A Check Activity page and see that it is full of Requests From User B: "Shared file %File List from the Notes Folder% was downloaded by User B via the browser" - each 10 min
Check Web Server Logs, there is 0 access requests from any Address.

Check audit.log and see massive access requests to all Notes under User B/Notes/*.* (there a different Notes, names replaced)

{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/Test.txt\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/NoteXX.txt\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/Versicherungsscheinnummer.txt\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Auslandsreisekrankenversicherung.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Example.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Note2.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Note3.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Note4.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Note5.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/Note26.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.txt\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.md\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.txt\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX.txt\"","userAgent":"--","version":"22.2.9.1"}
{"reqId":"h72xorOR0S0L8inJZehR","level":1,"time":"2022-07-07T09:25:03+00:00","remoteAddr":"","user":"User B","app":"admin_audit","method":"","url":"--","message":"File accessed: \"/Notes/TEST/NoteXX(3).md\"","userAgent":"--","version":"22.2.9.1"}

Disable Bookmarks App --> See 0 Requests.

Expected behavior Enabling of App should not drive to massive checks.

Screenshots grafik

Server (please complete the following information):

OS: Ubuntu 20.04
HTTP server: Apache/2.4.54
Database: 15.1 Distrib 10.3.34-MariaDB
PHP version: 7.4.30
Nextcloud version: 22.2.9.1
Bookmarks app version: 10.5.1

Activated Nextcloud Apps:

Enabled:
- accessibility: 1.8.0
- activity: 2.15.0
- admin_audit: 1.12.0
- audioplayer: 3.3.0
- bookmarks: 10.5.1
- bruteforcesettings: 2.4.0
- calendar: 3.4.1
- camerarawpreviews: 0.7.15
- checksum: 1.1.4
- cloud_federation_api: 1.5.0
- comments: 1.12.0
- contacts: 4.1.1
- contactsinteraction: 1.3.0
- cospend: 1.4.8
- dashboard: 7.2.0
- data_request: 1.9.0
- dav: 1.20.0
- deck: 1.5.8
- drawio: 1.0.3
- external: 3.9.0
- extract: 1.3.5
- facerecognition: 0.9.1
- federatedfilesharing: 1.12.0
- files: 1.17.0
- files_automatedtagging: 1.12.0
- files_downloadactivity: 1.13.0
- files_external: 1.13.1
- files_mindmap: 0.0.26
- files_pdfviewer: 2.3.1
- files_retention: 1.11.1
- files_rightclick: 1.1.0
- files_sharing: 1.14.0
- files_trashbin: 1.12.0
- files_versions: 1.15.0
- files_videoplayer: 1.11.0
- firstrunwizard: 2.11.0
- forms: 2.5.1
- gpxedit: 0.0.14
- gpxpod: 4.3.0
- integration_discourse: 1.0.2
- integration_github: 1.0.2
- integration_gitlab: 1.0.3
- keeweb: 0.6.9
- logreader: 2.7.0
- lookup_server_connector: 1.10.0
- mail: 1.13.6
- maps: 0.1.10
- nextcloud_announcements: 1.11.0
- notes: 4.3.1
- notifications: 2.10.1
- oauth2: 1.10.0
- ocdownloader: 1.8.0
- password_policy: 1.12.0
- phonetrack: 0.7.0
- photos: 1.4.0
- polls: 3.7.0
- previewgenerator: 5.0.0
- privacy: 1.6.0
- provisioning_api: 1.12.0
- recommendations: 1.1.0
- serverinfo: 1.12.0
- settings: 1.4.0
- sharebymail: 1.12.0
- side_menu: 2.4.1
- spreed: 12.2.6
- support: 1.5.0
- survey_client: 1.10.0
- systemtags: 1.12.0
- text: 3.3.1
- theming: 1.13.0
- transmission: 0.7.2
- twofactor_backupcodes: 1.11.0
- twofactor_totp: 6.4.0
- unsplash: 1.2.5
- updatenotification: 1.12.0
- user_status: 1.2.0
- video_converter: 1.0.5
- viewer: 1.6.0
- weather_status: 1.2.0
- workflowengine: 2.4.0

Nextcloud configuration:

{
"system": {
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "***REMOVED SENSITIVE VALUE***",
        "***REMOVED SENSITIVE VALUE***",
        "***REMOVED SENSITIVE VALUE***"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "overwrite.cli.url": "https:\/\/cloud.sitnikov.ga",
    "dbtype": "mysql",
    "version": "22.2.9.1",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "filesystem_check_changes": 0,
    "filelocking.enabled": true,
    "memcache.local": "\\OC\\Memcache\\APCu",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "memcache.distributed": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 0,
        "timeout": 1.5
    },
    "default_phone_region": "DE",
    "mail_smtpmode": "smtp",
    "mail_smtpauthtype": "LOGIN",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "maintenance": false,
    "theme": "",
    "logfile": "\/var\/nextcloud\/data\/nextcloud.log",
    "loglevel": 1,
    "trashbin_retention_obligation": "14, auto",
    "versions_retention_obligation": "14, auto",
    "data-fingerprint": "***REMOVED SENSITIVE VALUE***",
    "enable_previews": true,
    "enabledPreviewProviders": [
        "OC\\Preview\\PNG",
        "OC\\Preview\\JPEG",
        "OC\\Preview\\GIF",
        "OC\\Preview\\BMP",
        "OC\\Preview\\XBitmap",
        "OC\\Preview\\Movie",
        "OC\\Preview\\PDF",
        "OC\\Preview\\MP3",
        "OC\\Preview\\TXT",
        "OC\\Preview\\MarkDown"
    ],
    "preview_max_x": 1920,
    "preview_max_y": 1080,
    "jpeg_quality": 90,
    "auth.bruteforce.protection.enabled": true,
    "simpleSignUpLink.shown": false,
    "mail_sendmailmode": "smtp",
    "mail_smtpsecure": "tls",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "587",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "twofactor_enforced": true,
    "twofactor_enforced_groups": [
        "admin"
    ],
    "twofactor_enforced_excluded_groups": [],
    "has_rebuilt_cache": true,
    "updater.release.channel": "stable",
    "app_install_overwrite": [
        "transmission"
    ],
    "updater.secret": "***REMOVED SENSITIVE VALUE***"
}
}

Nextcloud external user backend: none

Additional context Add any other context about the problem here.

Web server error log

Nothing related

Nextcloud log (nextcloud/data/nextcloud.log)

Nothing related

Browser log

Nothing related

GAS85 commented 2 years ago

Additional information is also here https://help.nextcloud.com/t/periodical-not-clear-files-access/137592

marcelklehr commented 2 years ago

Thanks for reporting! This will be fixed in the next release!

GAS85 commented 2 years ago

It is somehow it is working, but I still have some questions...

After update to 11.0.1 User B do not produce any activity:

Bit User A now producing tons of file access logs entries in a audit.log. E.g. all requests with reqID: 9G9jJ3InOOgNvKAPKeBF are files access in Notes folder.

grep '"reqId":"9G9jJ3InOOgNvKAPKeBF"' /var/nextcloud/data/audit.log | wc -l
101

I suppose this app access Notes folder to fetch URLs and add them to bookmarks... Can you please add some info about this feature to the README.md? Also what kind of format should it be, e.g. simple line with URL or something else like all URLs from the text will be add to bookmarks. I see that it is specified here: https://github.com/nextcloud/bookmarks/blob/master/lib/Service/NotesService.php#L22 seems as simple URL in the text.

Also my suggestion is to check only recent modified files since last check, or e.g. all changed files in last hour or even day. This will reduce access dramatically and could be done via bash CLI or Nextcloud DB check.

marcelklehr commented 2 years ago

Also my suggestion is to check only recent modified files since last check, or e.g. all changed files in last hour or even day. This will reduce access dramatically and could be done via bash CLI or Nextcloud DB check.

Good idea!

nextcloud / bookmarks

Shared Notes will be massivly checked by Bookmarks --> Tons of Activites #1840