search

nextcloud / bookmarks

🔖 Bookmark app for Nextcloud
https://apps.nextcloud.com/apps/bookmarks
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Legacy cipher is no longer supported! #2099

Open nunesgh opened 11 months ago

nunesgh commented 11 months ago

Describe the bug Some of the Bookmarks app automatic backup files are not being synced through the Nextcloud Desktop app.

To Reproduce This error is triggered only for some automatic backup files created by the Bookmarks app.

Expected behavior The backup files would sync through the Nextcloud Desktop app and no "Legacy cipher" error would be logged.

Desktop (please complete the following information):

Server (please complete the following information):

Enabled: - activity: 2.19.0 - admin_audit: 1.17.0 - announcementcenter: 6.7.0 - bookmarks: 13.1.1 - bruteforcesettings: 2.7.0 - calendar: 4.5.3 - checksum: 1.2.2 - circles: 27.0.1 - cloud_federation_api: 1.10.0 - comments: 1.17.0 - contacts: 5.4.2 - contactsinteraction: 1.8.0 - dashboard: 7.7.0 - dav: 1.27.0 - drop_account: 2.3.2 - encryption: 2.15.0 - external: 5.2.1 - federatedfilesharing: 1.17.0 - federation: 1.17.0 - files: 1.22.0 - files_accesscontrol: 1.17.1 - files_antivirus: 5.4.0 - files_automatedtagging: 1.17.0 - files_external: 1.19.0 - files_pdfviewer: 2.8.0 - files_reminders: 1.0.0 - files_rightclick: 1.6.0 - files_sharing: 1.19.0 - files_trashbin: 1.17.0 - files_versions: 1.20.0 - fileslibreofficeedit: 1.1.0 - firstrunwizard: 2.16.0 - flow_notifications: 1.7.0 - forms: 3.4.2 - gpoddersync: 3.8.1 - guests: 2.5.0 - impersonate: 1.14.0 - integration_github: 2.0.6 - integration_gitlab: 1.0.18 - integration_mastodon: 2.0.3 - logreader: 2.12.0 - lookup_server_connector: 1.15.0 - news: 24.0.0 - nextcloud_announcements: 1.16.0 - nextpod: 0.7.3 - notifications: 2.15.0 - oauth2: 1.15.1 - password_policy: 1.17.0 - photos: 2.3.0 - polls: 5.4.2 - privacy: 1.11.0 - provisioning_api: 1.17.0 - quicknotes: 0.8.10 - quota_warning: 1.17.0 - recommendations: 1.6.0 - related_resources: 1.2.0 - richdocuments: 8.2.3 - richdocumentscode: 23.5.503 - serverinfo: 1.17.0 - settings: 1.9.0 - sharebymail: 1.17.0 - side_menu: 3.11.2 - support: 1.10.0 - survey_client: 1.15.0 - suspicious_login: 5.0.0 - systemtags: 1.17.0 - tables: 0.6.4 - tasks: 0.15.0 - text: 3.8.0 - theming: 2.2.0 - twofactor_admin: 4.3.0 - twofactor_backupcodes: 1.16.0 - twofactor_email: 2.7.4 - twofactor_totp: 9.0.0 - updatenotification: 1.17.0 - user_status: 1.7.0 - viewer: 2.1.0 - weather_status: 1.7.0 - workflow_ocr: 1.27.5 - workflow_pdf_converter: 1.12.0 - workflowengine: 2.9.0 Disabled: - integration_libretranslate: 1.1.1 (installed 1.1.1) - user_ldap: 1.17.0
``` { "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "cipher": "AES-256-CFB", "login_form_autocomplete": false, "trusted_domains": [ "***REMOVED SENSITIVE VALUE***" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "27.1.4.1", "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***", "htaccess.RewriteBase": "\/", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "enable_previews": true, "preview_max_x": 1024, "preview_max_y": 1024, "preview_max_scale_factor": 10, "enabledPreviewProviders": [ "OC\\Preview\\PNG", "OC\\Preview\\JPEG" ], "filelocking.enabled": true, "memcache.local": "\\OC\\Memcache\\Redis", "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379 }, "default_language": "***REMOVED SENSITIVE VALUE***", "default_locale": "***REMOVED SENSITIVE VALUE***", "default_phone_region": "***REMOVED SENSITIVE VALUE***", "defaultapp": "dashboard,files", "knowledgebaseenabled": true, "skeletondirectory": "", "maintenance": false, "twofactor_enforced": true, "twofactor_enforced_groups": [ "***REMOVED SENSITIVE VALUE***" ], "twofactor_enforced_excluded_groups": [ "***REMOVED SENSITIVE VALUE***" ], "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "ssl", "mail_smtpport": "465", "mail_smtpauthtype": "LOGIN", "mail_smtpauth": 1, "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "theme": "", "loglevel": 2, "logtimezone": "***REMOVED SENSITIVE VALUE***", "trashbin_retention_obligation": "auto, 180", "versions_retention_obligation": "auto", "updater.release.channel": "stable", "data-fingerprint": "87185c627a98d7f1ebc3c7888c4ad5ee", "connectivity_check_domains": [ "www.eff.org", "www.nextcloud.com" ], "quota_include_external_storage": false, "encryption.legacy_format_support": false } } ```

Additional context This issue has been happening since Nextcloud 24.

Nextcloud log (nextcloud/data/nextcloud.log)

``` [webdav] Error: Sabre\DAV\Exception: Legacy cipher is no longer supported! at <> 0. /var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php line 494 OCA\DAV\Connector\Sabre\File->convertToSabreException() 1. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php line 85 OCA\DAV\Connector\Sabre\File->get() 2. /var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php line 89 Sabre\DAV\CorePlugin->httpGet() 3. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 472 Sabre\DAV\Server->emit() 4. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 253 Sabre\DAV\Server->invokeMethod() 5. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 321 Sabre\DAV\Server->start() 6. /var/www/nextcloud/apps/dav/lib/Server.php line 365 Sabre\DAV\Server->exec() 7. /var/www/nextcloud/apps/dav/appinfo/v2/remote.php line 35 OCA\DAV\Server->exec() 8. /var/www/nextcloud/remote.php line 172 require_once("/var/www/nextcl ... p") Caused by: OC\ServerNotAvailableException: Legacy cipher is no longer supported! at <> 0. /var/www/nextcloud/apps/encryption/lib/Crypto/Encryption.php line 247 OCA\Encryption\Crypto\Crypt->getLegacyCipher() 1. /var/www/nextcloud/lib/private/Files/Stream/Encryption.php line 284 OCA\Encryption\Crypto\Encryption->begin() 2. <> OC\Files\Stream\Encryption->stream_open() 3. /var/www/nextcloud/lib/private/Files/Stream/Encryption.php line 212 fopen() 4. /var/www/nextcloud/lib/private/Files/Stream/Encryption.php line 187 OC\Files\Stream\Encryption::wrapSource() 5. /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Encryption.php line 483 OC\Files\Stream\Encryption::wrap() 6. /var/www/nextcloud/apps/files_antivirus/lib/AvirWrapper.php line 77 OC\Files\Storage\Wrapper\Encryption->fopen() 7. /var/www/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php line 298 OCA\Files_Antivirus\AvirWrapper->fopen() 8. /var/www/nextcloud/apps/files_accesscontrol/lib/StorageWrapper.php line 235 OC\Files\Storage\Wrapper\Wrapper->fopen() 9. /var/www/nextcloud/lib/private/Files/View.php line 1159 OCA\FilesAccessControl\StorageWrapper->fopen() 10. /var/www/nextcloud/lib/private/Files/View.php line 987 OC\Files\View->basicOperation() 11. /var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php line 492 OC\Files\View->fopen() 12. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php line 85 OCA\DAV\Connector\Sabre\File->get() 13. /var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php line 89 Sabre\DAV\CorePlugin->httpGet() 14. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 472 Sabre\DAV\Server->emit() 15. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 253 Sabre\DAV\Server->invokeMethod() 16. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 321 Sabre\DAV\Server->start() 17. /var/www/nextcloud/apps/dav/lib/Server.php line 365 Sabre\DAV\Server->exec() 18. /var/www/nextcloud/apps/dav/appinfo/v2/remote.php line 35 OCA\DAV\Server->exec() 19. /var/www/nextcloud/remote.php line 172 require_once("/var/www/nextcl ... p") GET /remote.php/dav/files/***REMOVED SENSITIVE VALUE***/2023-11-26.html from ***REMOVED SENSITIVE VALUE*** by ***REMOVED SENSITIVE VALUE*** at 2023-11-29T17:14:47-03:00 ```
github-actions[bot] commented 11 months ago

Hello :wave:

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue Cheers :blue_heart: