Loaded bookmarks (only viewed through the normal view) are added also to Trash Bin section

[estux]

Describe the bug I opened Bookmarks app and started navigating through folders I created (only viewing what bookmarks I have). Then I went to Trash Bin and seen the "viewed" items added also there. So I exited the app and then opened again (I have 3 bookmarks that aren't in any folder). Opened the Trash Bin and saw the 3 loaded bookmarks (the one seen in the previous view, that aren't in any folder, loaded in the main view) added also there. So every time you go out and come back the view in the Trash Bin is reset and shows only the "last viewed-navigated items" from the main view.

To Reproduce Steps to reproduce the behavior:

1. Open Bookmarks app
2. Have some bookmarks that aren't in any folder (e.g. 3 of them)
3. Click to see what bookmarks you have inside a folder (e.g. 8)
4. Open the Trash Bin
5. You can see 3+8 items "viewed" before in the Trash Bin view.
6. It seems that they aren't really trashed because if you come back to the main view you can still see e.g. the first 3 bookmarks (the ones that aren't in any folder)
7. Now you can try exiting Bookmarks app
8. open again Bookmarks app
9. In the main view the 3 bookmarks that aren't in any folder are automatically "loaded"
10. Go again to the Trash Bin to see only this 3 bookmarks in the Trash Bin view.

Expected behavior No bookmarks seen in the Trash Bin as I didn't trashed any bookmark.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Firefox
• Version: 126.0.1

Server (please complete the following information):

• OS: Linux 5.15.149-1-pve

• HTTP server: nginx/1.18.0 (fpm-fcgi)

• Database: mysql 10.5.23

• PHP version: 8.2.14

• Nextcloud version: 28.0.6

• Bookmarks app version: 14.1.1

• Activated Nextcloud Apps: Enabled:

• activity: 2.20.0

• bookmarks: 14.1.1

• bruteforcesettings: 2.8.0

• calendar: 4.7.6

• camerarawpreviews: 0.8.5

• circles: 28.0.0

• cloud_federation_api: 1.11.0

• collectives: 2.11.0

• comments: 1.18.0

• contacts: 5.5.3

• contactsinteraction: 1.9.0

• cospend: 1.6.1

• dashboard: 7.8.0

• dav: 1.29.1

• deck: 1.12.2

• federatedfilesharing: 1.18.0

• federation: 1.18.0

• files: 2.0.0

• files_pdfviewer: 2.9.0

• files_reminders: 1.1.0

• files_sharing: 1.20.0

• files_trashbin: 1.18.0

• files_versions: 1.21.0

• firstrunwizard: 2.17.0

• forms: 4.2.4

• groupfolders: 16.0.6

• inventory: 0.1.2

• logreader: 2.13.0

• lookup_server_connector: 1.16.0

• maps: 1.4.0

• news: 25.0.0-alpha3

• nextcloud_announcements: 1.17.0

• notes: 4.10.0

• notifications: 2.16.0

• oauth2: 1.16.3

• password_policy: 1.18.0

• photos: 2.4.0

• polls: 7.0.3

• privacy: 1.12.0

• provisioning_api: 1.18.0

• recommendations: 2.0.0

• related_resources: 1.3.0

• richdocuments: 8.3.7

• serverinfo: 1.18.0

• settings: 1.10.1

• sharebymail: 1.18.0

• spreed: 18.0.8

• support: 1.11.1

• survey_client: 1.16.0

• suspicious_login: 6.0.0

• systemtags: 1.18.0

• tables: 0.7.2

• tasks: 0.16.0

• text: 3.9.1

• theming: 2.3.0

• twofactor_backupcodes: 1.17.0

• updatenotification: 1.18.0

• user_status: 1.8.1

• viewer: 2.2.0

• weather_status: 1.8.0

• workflowengine: 2.10.0 Disabled:

• admin_audit

• carnet: 0.25.4

• encryption

• files_external

• files_rightclick: 1.6.0

• mail: 3.7.0

• twofactor_totp

• unsplash: 2.2.1

• user_ldap

• Nextcloud configuration: { "instanceid": "REMOVED SENSITIVE VALUE", "passwordsalt": "REMOVED SENSITIVE VALUE", "secret": "REMOVED SENSITIVE VALUE", "trusteddomains": [ "my domain (sensitive value)" ], "datadirectory": "REMOVED SENSITIVE VALUE", "dbtype": "mysql", "version": "28.0.6.1", "overwrite.cli.url": "https:\/\/my domain (sensitive value)", "dbname": "REMOVED SENSITIVE VALUE", "dbhost": "REMOVED SENSITIVE VALUE", "dbport": "", "dbtableprefix": "oc", "mysql.utf8mb4": true, "dbuser": "REMOVED SENSITIVE VALUE", "dbpassword": "REMOVED SENSITIVE VALUE", "installed": true, "logtimezone": "Europe\/Amsterdam", "maintenance": false, "loglevel": 0, "filesystem_check_changes": 1, "memcache.local": "\OC\Memcache\Redis", "redis": { "host": "REMOVED SENSITIVE VALUE", "port": 6379 }, "memcache.locking": "\OC\Memcache\Redis", "mail_smtpmode": "sendmail", "mail_smtpauthtype": "LOGIN", "mail_from_address": "REMOVED SENSITIVE VALUE", "mail_domain": "REMOVED SENSITIVE VALUE", "theme": "", "has_rebuilt_cache": true, "default_phone_region": "IT", "versions_retention_obligation": "auto,90", "trashbin_retention_obligation": "auto,30", "updater.release.channel": "stable" }

• Nextcloud external user backend: none

Additional context Add any other context about the problem here.

Web server error log

No errors related to Bookmarks seem to be recorded.

Nextcloud log (nextcloud/data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...

[github-actions[bot]]

Hello :wave:

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue Cheers :blue_heart:

[marcelklehr]

Confirmed.

[marcelklehr]

Workaround for now is to reload the page after accessing the trash bin

[estux]

Workaround for now is to reload the page after accessing the trash bin

@marcelklehr Thanks for looking into this and confirming! I'm fine with the workaround ...... I only hope it doesn't automatically trash some bookmarks!

[marcelklehr]

Yeah, I understand that it's disconcerting to see stuff in the bin that shouldn't be there. I'll fix this soon.

[estux]

Thank you so much for working so fast on this! :)