nextcloud / bookmarks

🔖 Bookmark app for Nextcloud
https://apps.nextcloud.com/apps/bookmarks
GNU Affero General Public License v3.0
1.02k stars 173 forks source link

Folder Hierarchy Not Shown After Import Until App Closed and Reopened (Nextcloud 30), Checkboxes Invisible #2238

Open drankinatty opened 3 hours ago

drankinatty commented 3 hours ago

Is your feature request related to a problem? Please describe.

I imported thousands of bookmarks from Firefox which were organized in hierarchical folders. The import captured the folder information but after import did not display the bookmarks in folders, but instead shows them arranged by tag in descending order of bookmarks per-tag.

This was very confusing. After import, left with hundreds of tags and hundreds of bookmarks I fumbled around to recreate a folder or two to began reorganizing. I then click this issue, which took me out of Nextcloud. Upon returning to Nextcloud, the bookmarks are now displayed in folder hierarchy. But now I have to delete the folders (of the same name, but with 0 bookmarks) that I thought I needed to create.

Describe the solution you'd like

After import, the display should be updated to show tag and folder, instead of just tag. Or better, just show the folder hierarchy with the left tag-pane collapsed. That would eliminate the confusion.

The select [x] checkboxes should always be visible whether selected or not.

Describe alternatives you've considered

Same as solution, above.

Additional context

Add any other context or screenshots about the feature request here.

The other issue is [x] select checkboxes are not visible unless the bookmark is dragged slightly which then activates and displays the checkbox. The checkbox should always be visible. Here is what I don't see for checkboxes:

Image

It was very confusing to even discover the select feature.

github-actions[bot] commented 3 hours ago

Hello :wave:

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with less time for side projects like this one than I used to have. I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it. Until then, please be patient. Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue Cheers :blue_heart:

drankinatty commented 2 hours ago

Marcel,

While I'm looking at bookmarks from a first impression standpoint there is one other issue I just noticed check clicking the "details" view of a bookmark.

Content pending

I do not enable download of offline content. I just don't need it, and don't want the tens of megabytes of additional info pulled from the web for thousands of bookmarks. That said, I see how it is useful for those that want it. Currently, the following is displayed over a majority of the screen when detailed view is selected:

Image

If the setting to enable download of offline content isn't enabled, then all that screen real-estate is simply wasted. It would be helpful to just continue to display the bookmark (I use list view anyway).

Just something else I noticed that I thought I'd pass along. The app is very nice and I was really impressed the firefox bookmark import went at well as it did.

The only other note is the very, very long delay on opening the app while it counts all the bookmarks in each folder and for each tag. That can take a long 30 seconds while the interface is basically frozen. Granted, most people will have less than 2,200+ bookmarks to count, but I'm sure some people have more. It would be worthwhile to measure performance for bookmark counts every thousand between 1 and 10 thousand and see if it may not help to simply fork or spawn a separate process to do all the counting while the interface remains responsive to commands.

Let me know if you need anything else and I'm happy to provide it.