Closed Valdnet closed 4 years ago
@Valdnet Can you please provide the entire issue template including logs?
@georgehrke There is no error in the log. I'm trying to load a copy of the calendar from an xxx.ics file made from the old version 1.7.1. Nothing happens when the backup file is selected via "Import calendar".
@Valdnet Please check the browser log. There must be something in there.
@georgehrke In Firefox 72.0.2 browser logs, when importing a file, only this:
Initial settings:
Object { appVersion: "2.0.1", firstRun: true, showWeekends: true, showWeekNumbers: false, skipPopover: false, talkEnabled: false, timezone: "automatic" }
settings.js:87:2
[DEBUG] calendar: The calendar app is using version 2.2019c of the timezone database
Object { app: "calendar", uid: "authenticated:xxx" }
ConsoleLogger.js:44:18
[DEBUG] calendar: Current user principal is /remote.php/dav/principals/users/xxx/
Object { app: "calendar", uid: "authenticated:xxx" }
ConsoleLogger.js:44:18
user changed files SettingsImportSection.vue:146
@Valdnet Can you still please fill the entire issue template?
This seems to be specific to some browser / os combination.
@georgehrke I am supplementing the missing data:
Browser: (e.g. Firefox 48) Firefox 72.0.2
Operating system: (e.g. Arch Linux) Win7 and Win10
Operating system: (e.g. Debian 8) Linux
Web server: (e.g. Apache, Nginx,...) Apache 2.4.39
Database: (e.g. MariaDB, SQLite or PostgreSQL) Mysql
PHP version: (e.g. 7.0.3) 7.2.14
Nextcloud Version: (see admin page, e.g. 17.0.2) 18.0.0
List of activated apps: Accessibility 1.4.0 Activity 2.11.0 Brute-force settings 1.5.0 Calendar 2.0.1 Collaborative tags 1.8.0 Comments 1.8.0 Deleted files 1.8.0 Federation 1.8.0 File sharing 1.10.1 First run wizard 2.7.0 Log Reader 2.3.0 Monitoring 1.8.0 Nextcloud announcements 1.7.0 Notes 3.1.1 Notifications 2.6.0 Password policy 1.8.0 PDF viewer 1.7.0 Photos 1.0.0 Privacy 1.2.0 Quick notes 0.2.2 Recommendations 0.6.0 Right click 0.15.2 Share by mail 1.8.0 Splash 1.1.4 Support 1.1.0 Tasks 0.11.3 Text 2.0.0 Theming 1.9.0 Update notification 1.8.0 Usage survey 1.6.0 Versions 1.11.0 Video player 1.7.0 Auditing / Logging 1.8.0 Default encryption module 2.6.0 External storage support 1.9.0 LDAP user and group backend 1.8.0
So you are saying you to go settings, click "Import calendars", select a file, but then you never see this dialog?
Yes. This window does not appear for me.
Happens here, too. This is in the Chrome console:
calendar.js?v=c1e984bb-0:2 rmessage: "invalid ical body. component began but did not end"name: "ParserError"stack: " at new r (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:152314)β΅ at Object.i [as parse] (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:152543)β΅ at t.value (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:2176175)β΅ at t.value (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:2174114)β΅ at a.<anonymous> (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:2268903)β΅ at c (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:1011658)β΅ at Generator._invoke (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:1011411)β΅ at Generator.forEach.e.<computed> [as next] (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:1012015)β΅ at md (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:2266416)β΅ at a (https://nextcloudhost/apps/calendar/js/calendar.js?v=c1e984bb-0:2:2266620)"__proto__: constructor: Ζ Error()name: "Error"message: ""toString: Ζ toString()arguments: (...)caller: (...)length: 0name: "toString"__proto__: Ζ ()[[Scopes]]: Scopes[0]__proto__: Objectconstructor: Ζ Object()__defineGetter__: Ζ __defineGetter__()__defineSetter__: Ζ __defineSetter__()hasOwnProperty: Ζ hasOwnProperty()__lookupGetter__: Ζ __lookupGetter__()__lookupSetter__: Ζ __lookupSetter__()isPrototypeOf: Ζ isPrototypeOf()propertyIsEnumerable: Ζ propertyIsEnumerable()toString: Ζ toString()valueOf: Ζ valueOf()toLocaleString: Ζ toLocaleString()get __proto__: Ζ __proto__()set __proto__: Ζ __proto__()
Nextcloud 17.0.2, Calendar 2.0.1, ics was exported from Google Calendar
@meilon Looking at the error message, it seems to be an invalid or incomplete ics.
Can you upload the file to https://icalendar.org/validator.html to check?
Thanks for the link, it mentioned something about CRLF in the first line, but it looked fine in Notepad++. I changed the file endings to Windows (it was Mac with CR), the validator was happy and the import worked. So adding an error dialog with a hint to the validator would be helpful, though the best solution would be if the importer wouldn't be so picky π. I know the specs require CRLF, but come on π
So worked for me, don't know if @Valdnet's issue is the same.
So adding an error dialog with a hint to the validator would be helpful
@meilon Absolute true about the better feedback, opened an issue for that: https://github.com/nextcloud/calendar/issues/1920
though the best solution would be if the importer wouldn't be so picky
Let's see what we can do about it, I opened an issue for now to keep track: https://github.com/georgehrke/calendar-js/issues/78
@Valdnet Can you please check the file you are trying to import with https://icalendar.org/validator.html as well?
@georgehrke I checked the file. Result below:
File Size: 547 lines, 12339 bytes
Number of events found: 34
Number of timezones found: 1
Success! No errors found.
I have the same problem. After selecting the file, nothing happens. The dialog is not shown (Firefox 72.0.2).
Nextcloud 18.0.0, Calendar 2.0.1, ics file exported from old owncloud installation. The ics file was validated successfully with https://icalendar.org/validator.html
Edit: After reading the comment below, I tried the same with Chrome, where the import worked fine!
However I noticed some other things (not strictly related to the main issue):
After clicking Cancel on the import popup and trying to repeat the steps, the import popup will not show again
Clicking at the white space of the popup, the hidden Settings & Import area at the bottom left minimizes
German translation has an error (escaped non-breaking space at the end)
Bitte wΓ€hle einen Kalender aus in den importiert werden soll β¦
Selecting New calendar as destination on the import popup gives a JS error:
Uncaught (in promise) TypeError: Cannot set property 'loading' of undefined
at u.markCalendarAsLoading (calendar.js?v=804730c0-1:2)
at calendar.js?v=804730c0-1:2
at calendar.js?v=804730c0-1:2
at Array.forEach (<anonymous>)
at calendar.js?v=804730c0-1:2
at u._withCommit (calendar.js?v=804730c0-1:2)
at u.commit (calendar.js?v=804730c0-1:2)
at Object.commit (calendar.js?v=804730c0-1:2)
at calendar.js?v=804730c0-1:2
at c (calendar.js?v=804730c0-1:2)
I have the same problem. Firefox 72.0.2, Nextcloud 17.0.3, Calendar 2.0.1.
Edit: With Google Chrome, the popup appears, but no events is visible in the calendar. ICS file used: https://raw.githubusercontent.com/AntoineAugusti/jours-feries-france-datagouv/master/jours_feries.ics (saved as .ics file).
And here another one with exactly the same issue: No window after selecting ICS file and clicking ok. (ICS file checked with https://icalendar.org/validator.html)
Browser: (e.g. Firefox 48) Firefox 73.01 (64bit) and Microsoft Edge 44.18362.449.0
Operating system client: (e.g. Arch Linux) Win10 1903, 64bit
Operating system NC server: (e.g. Debian 8) Debian 9
Web server: (e.g. Apache, Nginx,...) Apache 2.4.25
Database: (e.g. MariaDB, SQLite or PostgreSQL) MariaDB
PHP version: (e.g. 7.0.3) PHP 7.2.27-5+0/~20200202.35+debian9/~1.gbp2925f8
Nextcloud Version: (see admin page, e.g. 17.0.2) 17.0.3
List of activated apps: Accessibility 1.3.0 Activity 2.10.1 Calendar 2.0.1 Collaborative tags 1.7.0 Comments 1.7.0 Contacts 3.1.8 Deleted files 1.7.0 Federation 1.7.0 File sharing 1.9.0 First run wizard 2.6.0 Gallery 18.4.0 Log Reader 2.2.0 Monitoring 1.7.0 Nextcloud announcements 1.6.0 Notes 3.1.5 Notifications 2.5.0 Password policy 1.7.0 PDF viewer 1.6.0 Preview Generator 2.2.0 Privacy 1.1.0 Recommendations 0.5.0 Right click 0.15.1 Share by mail 1.7.0 Support 1.0.1 Tasks 0.11.3 Text 1.1.1 Theming 1.8.0 Update notification 1.7.0 Usage survey 1.5.0 Versions 1.10.0 Video player 1.6.0 Viewer 1.2.0
@tcitworld Thanks for the info. I looked into the solutions and tried them. Unfortunately, they do not work in my case! Accordingly, this issue should stay open.
@LittleAlf What line endings does the ics file have?
@georgehrke CRLF They are exports of single calendar entries from Microsoft Outlook 2016. Shall I try it by converting them to LF?
I just tried it, replacing all CRLF with LF: Nothing. The window to choose the calendar to import the entries does not pop up. No error message.
@LittleAlf anything in the console in your browser?
Same here. No error, no log entry no graphical change at all while trying to import several different ics files (checked them before import). Nextcloud 18.0.1 & Calendar 2.0.1 Client: Firefox 73.0.1
@golfben no log entry in the nextcloud.log or also nothing in the browser log?
@georgehrke no log entry in nextcloud.log. In my browser log it does only logs "user changed files", but no error either.
Exact same issue, same Firefox version, same browser logs.
@Pofilo I'm not able to reproduce that in Firefox on macOS.
I fear this issue is somehow related Windows.
Just tested it on another Nextcloud-installation (17.0.3) with the same browser and same calender app version. I get the same behavior here. @georgehrke This modal doesnt appear at all.
@golfben Are you using Firefox on Windows (7 or 10) as well?
I was able to reproduce this bug with the ics file provided by @Pofilo in a Firefox 62 on Windows. Looking into it now.
@georgehrke Yes, I am using Firefox 73.0.1 on Windows 10 - just tested it additionally on Microsoft Edge 44.18362.449.0 - doesnt work here either. Let me know if you need some more information or testing.
For me (NC 18.0.1, Windows 10 1909, Firefox 73.0.1, Edge, Export from NC 17.0.3) the import does not work either.
There is a pull-request to fix this bug in https://github.com/nextcloud/calendar/pull/2025
It works again with 2.0.2 and firefox. thank you!
It works again with 2.0.2 and firefox. thank you!
Same here. I can confirm. Thanks, guys!
It works again with 2.0.2 and firefox. thank you!
Same here. No problems importing anymore - Firefox 73.0.1 (64-bit).
Thank you very much!
Works properly. Thanks π.
Steps to reproduce
Expected behaviour
Import calendar from file.
Actual behaviour
No display of tasks from calendar import from file.
Calendar app
Calendar app version: (see apps admin page, e.g. 2.0.1) 2.0.1
Server configuration
Nextcloud Version: (see admin page, e.g. 17.0.2) 18.0.0