nextcloud / calendar

📆 Calendar app for Nextcloud
https://apps.nextcloud.com/apps/calendar
GNU Affero General Public License v3.0
981 stars 241 forks source link

Email address not shown for person who booked an appointment #3853

Open Bubu opened 2 years ago

Bubu commented 2 years ago

Steps to reproduce

  1. Offer bookable appointments
  2. As a non-logged in user book an appointment
  3. Click on the email confirmation link
  4. As the person offering the appointments, look at the created calendar entry and try and find a contact address for the person who booked the appointment

Expected behaviour

Name and mail address are shown, perhaps with a mailto: link/button

Actual behaviour

No address is shown. You can downlaod the event and try and import it into thunderbird to see the address. (So it's in the event, just not shown).

Calendar app

Calendar app version: 3.0.3

CalDAV-clients used: Thunderbird... but this is solely done via the web-interface here

Client configuration

Browser: FF 95.0.2

Operating system: Arch Linux

Server configuration

Operating system: Arch Linux

Web server: Nginx

Database: PostgreSQL

PHP version: 8.0.14

Nextcloud Version: 23.0.0

Updated from an older installed version or fresh install: Upgraded from Owncloud 8 or 9 or so... :D

List of activated apps:

  - accessibility: 1.9.0
  - activity: 2.15.0
  - audioplayer: 3.2.3
  - bookmarks: 10.0.3
  - calendar: 3.0.3
  - camerarawpreviews: 0.7.15
  - circles: 23.0.0
  - cloud_federation_api: 1.6.0
  - comments: 1.13.0
  - contacts: 4.0.7
  - contactsinteraction: 1.4.0
  - dashboard: 7.3.0
  - dav: 1.21.0
  - deck: 1.6.0
  - federatedfilesharing: 1.13.0
  - federation: 1.13.0
  - files: 1.18.0
  - files_external: 1.15.0
  - files_markdown: 2.3.5
  - files_pdfviewer: 2.4.0
  - files_rightclick: 1.2.0
  - files_sharing: 1.15.0
  - files_trashbin: 1.13.0
  - files_versions: 1.16.0
  - files_videoplayer: 1.12.0
  - firstrunwizard: 2.12.0
  - gpxpod: 4.3.0
  - logreader: 2.8.0
  - lookup_server_connector: 1.11.0
  - mail: 1.11.4
  - news: 17.0.1
  - nextcloud_announcements: 1.12.0
  - notes: 4.2.0
  - notifications: 2.11.1
  - oauth2: 1.11.0
  - ocsms: 2.2.0
  - passman: 2.4.0
  - password_policy: 1.13.0
  - photos: 1.5.0
  - previewgenerator: 3.4.1
  - privacy: 1.7.0
  - provisioning_api: 1.13.0
  - recommendations: 1.2.0
  - richdocuments: 5.0.1
  - serverinfo: 1.13.0
  - settings: 1.5.0
  - sharebymail: 1.13.0
  - spreed: 13.0.1
  - support: 1.6.0
  - survey_client: 1.11.0
  - systemtags: 1.13.0
  - tasks: 0.14.2
  - text: 3.4.0
  - theming: 1.14.0
  - twofactor_backupcodes: 1.12.0
  - twofactor_totp: 6.2.0
  - twofactor_u2f: 6.3.0
  - updatenotification: 1.13.0
  - user_status: 1.3.1
  - viewer: 1.7.0
  - weather_status: 1.3.0
  - workflowengine: 2.5.0

Nextcloud configuration:

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.bubu1.eu"
        ],
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "dbindex": 3,
            "port": 0,
            "timeout": 0
        },
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "apps_paths": [
            {
                "path": "\/usr\/share\/webapps\/nextcloud\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/lib\/nextcloud\/apps",
                "url": "\/wapps",
                "writable": true
            }
        ],
        "logfile": "\/var\/log\/nextcloud\/nextcloud.log",
        "dbtype": "pgsql",
        "version": "23.0.0.10",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "forcessl": true,
        "mail_smtpmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 0,
        "theme": "",
        "maintenance": false,
        "trashbin_retention_obligation": "auto",
        "htaccess.RewriteBase": "\/",
        "overwrite.cli.url": "https:\/\/cloud.bubu1.eu\/",
        "updater.release.channel": "stable",
        "app_install_overwrite": [
            "passman",
            "mail",
            "tasks",
            "calendar",
            "audioplayer",
            "ocsms",
            "ocr",
            "camerarawpreviews"
        ],
        "mail_sendmailmode": "smtp",
        "preview_libreoffice_path": "\/usr\/bin\/libreoffice",
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\HEIC",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\OpenDocument"
        ],
        "default_phone_region": "DE"
    }
}

Logs

Can provide logs if necessary. Nextcloud logs didn't show any warnings or errors.

Web server error log (e.g. /var/log/apache)


-

#### Log file (data/nextcloud.log)
-

#### Browser log
-
ChristophWurst commented 2 years ago

the booking person is an attendee. have you checked the attendees?

Bubu commented 2 years ago

Yes, it's not shown there:

image

Bubu commented 2 years ago

Should I create another issue for the broken avatars on that view? (possibly related browser errors?)

image

ChristophWurst commented 2 years ago

The avatars are addressed by https://github.com/nextcloud/calendar/pull/3101. Related to https://github.com/nextcloud/calendar/issues/3099.

ChristophWurst commented 2 years ago

Yes, it's not shown there:

Okay, so you expected to also see the name and contact info in the event description, right? That's a valid feature request. Could you resubmit it as such?

Bubu commented 2 years ago

(Thanks for taking the time to walk through these issues with me, it's very much appreciated :-))

Okay, so you expected to also see the name and contact info in the event description, right?

I think I'm not asking for that, I think having it on the attendee screen is enough. What I would expect there though is for non-users of the instance you are on to show the something like Name <name@example.com>, if the info is in the event.

(I can still resubmit that as a feature request, if you prefer.)

42ske commented 2 years ago

I would have the same feature request: show email addresses on the attendee screen and add the ability to directly create a new manual mail to the attendee (maybe additional to all attendees also). The info ist already there it is just not displayed in the calendar via browser, if you sync your calendards with external calendar apps the the mailadresses can be seen (e.g. macOS Calendar).

maximelehericy commented 2 years ago

In Thunderbird, the email address of the person who booked is shown. It is maybe just a matter of display in Nextcloud Calendar :) image

maximelehericy commented 1 year ago

BTW, this issue is also true for regular calendar invitations that do not come from the Appointment feature. However, it is especially painful in the Appointment feature as the main user often do not know who is the requester.

ChristophWurst commented 1 year ago

I suggest we put an action text component into the attendee actions (... menu) that shows the email address. That is easy to do and sufficient.

Ref https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactiontext

maximelehericy commented 1 year ago

I suggest we put an action text component into the attendee actions (... menu) that shows the email address. That is easy to do and sufficient.

Ref https://nextcloud-vue-components.netlify.app/#/Components/NcActions?id=ncactiontext

What is an action text ? (apologies for my non-dev noob questions 🙃)

ChristophWurst commented 1 year ago

A text entry in an actions menu

maximelehericy commented 1 year ago

hmmm, let's wait for the result :)

ChristophWurst commented 1 year ago

Bildschirmfoto vom 2022-11-18 17-48-32

^ this is an actions menu. the first entry is a text. the rest are buttons.